diff options
author | Russ Cox <rsc@golang.org> | 2019-05-08 13:59:48 -0400 |
---|---|---|
committer | Russ Cox <rsc@golang.org> | 2019-05-09 21:13:22 +0000 |
commit | 49f62af790c02c389d34a24227a17ddd4b4db94a (patch) | |
tree | e86c484a2cf0b20b88a89ce1a682e4a0727274a8 /src/cmd/vet | |
parent | 1ea76443ba1825f03e187157b3f58560c52609b9 (diff) | |
download | go-49f62af790c02c389d34a24227a17ddd4b4db94a.tar.gz go-49f62af790c02c389d34a24227a17ddd4b4db94a.zip |
runtime: fix vet complaints for linux/arm64, linux/mips*, linux/ppc64*, linux/s390x
Working toward making the tree vet-safe instead of having
so many exceptions in cmd/vet/all/whitelist.
This CL makes "go vet -unsafeptr=false runtime" happy for these GOOS/GOARCHes,
except for an unresolved complaint on mips/mipsle that is a bug in vet,
while keeping "GO_BUILDER_NAME=misc-vetall go tool dist test" happy too.
For #31916.
Change-Id: I6ef7e982a2fdbbfbc22cee876ca37ac54d8109e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/176102
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src/cmd/vet')
-rw-r--r-- | src/cmd/vet/all/whitelist/aix_ppc64.txt | 5 | ||||
-rw-r--r-- | src/cmd/vet/all/whitelist/arm64.txt | 5 | ||||
-rw-r--r-- | src/cmd/vet/all/whitelist/linux_ppc64x.txt | 4 | ||||
-rw-r--r-- | src/cmd/vet/all/whitelist/mips.txt | 7 | ||||
-rw-r--r-- | src/cmd/vet/all/whitelist/mipsle.txt | 7 |
5 files changed, 0 insertions, 28 deletions
diff --git a/src/cmd/vet/all/whitelist/aix_ppc64.txt b/src/cmd/vet/all/whitelist/aix_ppc64.txt deleted file mode 100644 index bfd76e9055..0000000000 --- a/src/cmd/vet/all/whitelist/aix_ppc64.txt +++ /dev/null @@ -1,5 +0,0 @@ -// aix/ppc64-specific vet whitelist. See readme.txt for details. - -runtime/asm_ppc64x.s: [ppc64] sigreturn: function sigreturn missing Go declaration -runtime/sys_aix_ppc64.s: [ppc64] _asmsyscall6: function _asmsyscall6 missing Go declaration -runtime/sys_aix_ppc64.s: [ppc64] _tstart: function _tstart missing Go declaration diff --git a/src/cmd/vet/all/whitelist/arm64.txt b/src/cmd/vet/all/whitelist/arm64.txt deleted file mode 100644 index cd9577b7b5..0000000000 --- a/src/cmd/vet/all/whitelist/arm64.txt +++ /dev/null @@ -1,5 +0,0 @@ -// arm64-specific vet whitelist. See readme.txt for details. - -// Intentionally missing declarations. -runtime/tls_arm64.s: [arm64] load_g: function load_g missing Go declaration -runtime/tls_arm64.s: [arm64] save_g: function save_g missing Go declaration diff --git a/src/cmd/vet/all/whitelist/linux_ppc64x.txt b/src/cmd/vet/all/whitelist/linux_ppc64x.txt deleted file mode 100644 index 0091d97110..0000000000 --- a/src/cmd/vet/all/whitelist/linux_ppc64x.txt +++ /dev/null @@ -1,4 +0,0 @@ -// linux/ppc64-specific vet whitelist. See readme.txt for details. - -runtime/sys_linux_ppc64x.s: [GOARCH] _sigtramp: function _sigtramp missing Go declaration -runtime/sys_linux_ppc64x.s: [GOARCH] _cgoSigtramp: function _cgoSigtramp missing Go declaration diff --git a/src/cmd/vet/all/whitelist/mips.txt b/src/cmd/vet/all/whitelist/mips.txt deleted file mode 100644 index fa17c6233b..0000000000 --- a/src/cmd/vet/all/whitelist/mips.txt +++ /dev/null @@ -1,7 +0,0 @@ -// mips-specific (big endian) vet whitelist. See readme.txt for details. - -// Work around if-def'd code. Will be fixed by golang.org/issue/17544. -runtime/sys_linux_mipsx.s: [mips] walltime: invalid offset sec_lo+0(FP); expected sec_lo+4(FP) -runtime/sys_linux_mipsx.s: [mips] walltime: invalid offset sec_hi+4(FP); expected sec_hi+0(FP) -runtime/sys_linux_mipsx.s: [mips] nanotime: invalid offset ret_lo+0(FP); expected ret_lo+4(FP) -runtime/sys_linux_mipsx.s: [mips] nanotime: invalid offset ret_hi+4(FP); expected ret_hi+0(FP) diff --git a/src/cmd/vet/all/whitelist/mipsle.txt b/src/cmd/vet/all/whitelist/mipsle.txt deleted file mode 100644 index 9361dc4353..0000000000 --- a/src/cmd/vet/all/whitelist/mipsle.txt +++ /dev/null @@ -1,7 +0,0 @@ -// mipsle-specific vet whitelist. See readme.txt for details. - -// Work around if-def'd code. Will be fixed by golang.org/issue/17544. -runtime/sys_linux_mipsx.s: [mipsle] walltime: invalid offset sec_lo+4(FP); expected sec_lo+0(FP) -runtime/sys_linux_mipsx.s: [mipsle] walltime: invalid offset sec_hi+0(FP); expected sec_hi+4(FP) -runtime/sys_linux_mipsx.s: [mipsle] nanotime: invalid offset ret_lo+4(FP); expected ret_lo+0(FP) -runtime/sys_linux_mipsx.s: [mipsle] nanotime: invalid offset ret_hi+0(FP); expected ret_hi+4(FP) |