aboutsummaryrefslogtreecommitdiff
path: root/src/cmd/vet
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2019-05-08 13:43:44 -0400
committerRuss Cox <rsc@golang.org>2019-05-09 21:13:21 +0000
commit1ea76443ba1825f03e187157b3f58560c52609b9 (patch)
tree397a3e7fcce957ae462a5f30a64fdd172edcbbeb /src/cmd/vet
parentfe67ce2efb243b9289e81a61a5ccae79b75048f2 (diff)
downloadgo-1ea76443ba1825f03e187157b3f58560c52609b9.tar.gz
go-1ea76443ba1825f03e187157b3f58560c52609b9.zip
runtime: fix vet complaints for linux/arm
Working toward making the tree vet-safe instead of having so many exceptions in cmd/vet/all/whitelist. This CL makes "GOOS=linux GOARCH=arm go vet -unsafeptr=false runtime" happy, while keeping "GO_BUILDER_NAME=misc-vetall go tool dist test" happy too. For #31916. Change-Id: Ifae75b832320b5356ac8773cf85055bfb2bd7214 Reviewed-on: https://go-review.googlesource.com/c/go/+/176101 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/cmd/vet')
-rw-r--r--src/cmd/vet/all/whitelist/android_arm.txt4
-rw-r--r--src/cmd/vet/all/whitelist/arm.txt7
-rw-r--r--src/cmd/vet/all/whitelist/linux_arm.txt5
3 files changed, 0 insertions, 16 deletions
diff --git a/src/cmd/vet/all/whitelist/android_arm.txt b/src/cmd/vet/all/whitelist/android_arm.txt
deleted file mode 100644
index dda4fb539d..0000000000
--- a/src/cmd/vet/all/whitelist/android_arm.txt
+++ /dev/null
@@ -1,4 +0,0 @@
-// android/arm-specific vet whitelist. See readme.txt for details.
-
-runtime/sys_linux_arm.s: [arm] clone: 12(R13) should be stk+4(FP)
-runtime/sys_linux_arm.s: [arm] clone: 8(R13) should be flags+0(FP)
diff --git a/src/cmd/vet/all/whitelist/arm.txt b/src/cmd/vet/all/whitelist/arm.txt
deleted file mode 100644
index 307f17bac8..0000000000
--- a/src/cmd/vet/all/whitelist/arm.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-// arm-specific vet whitelist. See readme.txt for details.
-
-// Intentionally missing declarations.
-runtime/asm_arm.s: [arm] emptyfunc: function emptyfunc missing Go declaration
-runtime/asm_arm.s: [arm] usplitR0: function usplitR0 missing Go declaration
-runtime/tls_arm.s: [arm] load_g: function load_g missing Go declaration
-runtime/tls_arm.s: [arm] _initcgo: function _initcgo missing Go declaration
diff --git a/src/cmd/vet/all/whitelist/linux_arm.txt b/src/cmd/vet/all/whitelist/linux_arm.txt
deleted file mode 100644
index a911700c3d..0000000000
--- a/src/cmd/vet/all/whitelist/linux_arm.txt
+++ /dev/null
@@ -1,5 +0,0 @@
-// linux/arm-specific vet whitelist. See readme.txt for details.
-
-// These SP references occur after a stack-altering call. They're fine.
-runtime/sys_linux_arm.s: [arm] clone: 12(R13) should be stk+4(FP)
-runtime/sys_linux_arm.s: [arm] clone: 8(R13) should be flags+0(FP)