| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
CAA Extensions for the Tor Rendezvous Specification.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Closes: #199.
|
|
This commit adds an explanation of the meaning behind the EXP(a, b)
function, primarily targeted for readers without a deep understanding of
the cryptography.
Fixes #195
|
|
This commit removes the redundant MULT(a, b) function from the ntor
section, as the function is defined but never used.
|
|
|
|
|
|
Specifically, you can look at the directory to see if somebody is
lying about a relay (mismatched IDs, etc), but you can't modify
the list of linkspecs.
|
|
We can make these non-mandatory in the future if we want, using a
consensus flag.
|
|
This resolved "problem 2" from torspec#193.
|
|
We were previously a bit unclear on how to handle multiple linkspecs
of type ed25519, and our spec didn't actually permit Tor's current
behavior.
Now we say that both Ed25519 ID and Legacy ID linkspecs MUST appear
at most once in a list of linkspecs, and that parties SHOULD
enforce this.
This is "problem 1" on torspec#193.
|
|
|
|
|
|
I found src/lib/encoding/binascii.[ch] in the C Tor codebase.
It has
#define BASE32_CHARS "abcdefghijklmnopqrstuvwxyz234567"
The function "base32_encode" says "Implements base32 encoding as in
RFC 4648.". Now, that RFC says that it's supposed to be padded unless
explicitly stated otherwise. However, the padding is pointless and
neither our "base32_encode" nor our "base32_decode" seem to implemnet
it.
I hope that we are using the same base32 encoding everywhere, but have
not checked.
|
|
Really, AUTH_KEY in the display ought to be KP_IPT_SID, to get rid of
a layer of terminological indirection.
|
|
The previous wording implied that SIG_LEN was also signed, which
it isn't.
|
|
|
|
|
|
|
|
|
|
|
|
These new names are the ones used in arti's hsdir_ring.rs and make a
lot more sense than calling one of them the "directory" index and
the other just the "index".
In C Tor these are calculated by functions called
hs_build_hs_index
hs_build_hsdir_index
That might be a reason *not* to accept this change. Or it might be a
reason to change the C Tor code.
If we don't change the names in the spec the Arti function names
should change.
|
|
It was never implemented, is not specified, and neither dgoulet nor
I can quite remember how it was supposed to work.
|
|
By our current logic, it needs to have `hs` in it.
|
|
It has no independent existence outside of the encryption algorithm
of 2.5.3.
|
|
|
|
These names are slightly shorter and a bit more descriptive IMO, and
now (when they are still fresh) is the best time to rename these
keys.
`hs_intro_tid` becomes `hs_ipt_sid`: It is a _session identifier_
key used with an _introduction point_. Using `ipt` here emphasizes
that it is not part of the introduction _handshake_.
`hs_intro_ntor` becomes `hss_ntor`. The extra "s" means it is owned
by the service. Renaming "intro" here removes the implication that
it is held by or used by the introduction point.
`onion_ntor` becomes `ntor`: There is no such thing as an ntor key
that is not an onion key.
|
|
Fix terminology for handshake type
See merge request tpo/core/torspec!112
|
|
Call the key in desc-auth-ephemeral-key, KP_hs_desc_ephem
See merge request tpo/core/torspec!111
|
|
|
|
Use the phrase which is used elsehwer, and enumerate them again since
this is where one would expect to find that enumeration.
|
|
We're not the code, we're the spec. We can define things, not
recognise them.
|
|
|
|
|
|
The phrase "format number" is not defined anywhere. I think it means
an HTYPE value.
|
|
|
|
|
|
Proposed by @nickm in
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/999/diffs#50f9790ab3f0a65f7ac3e4f413c84f51fae1f855_0_26
(I think the spec is not 100% clear that hs_y and hs_Y are *this* key,
rather than some other possible ephemeral keypair the HS might have,
so please would the reviewer check that this is actually true.)
|
|
Specifically:
* Mention this change in the introduction.
* Add a section explaining how to change tor-spec
and related proposals.
|
|
(See text for more info!)
|
|
The spec says "exactly once", but that only refers to the ntor
variant.
|
|
|
|
It looks like C tor doesn't include a final newline in the middle
layer of its onion service descriptors. That made arti reject them
the first time I tried to parse one! Here I document this behavior,
and tell other implementations what to do.
|
|
|
|
* The syntax `IN [a,b]` means that a and b are the only valid options,
which isn't what we want to say here.
* I'm changing the hostname tag to 0, which is the same as we have for
RESOLVED cells.
|
|
|
