aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2024-12-03process: Don't close all FDs on new spawnDavid Goulet
Fixes #40990 Signed-off-by: David Goulet <dgoulet@torproject.org>
2024-12-03Revert "Rework of worker threads' start and exit + slight changes in cleanup ↵David Goulet
code" This reverts commit 4f3aafa1e422e9aa005b74c8a1d40cc3e9143346. Once merged upstream, the CI failed here with: Warning: Failed to confirm worker threads' start up after timeout. Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(_start+0x2a) [0x56404d21ddaa] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(cpuworker_init+0x53) [0x56404d373d53] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(log_backtrace_impl+0x57) [0x56404d29e1f7] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(main+0x19) [0x56404d21dd59] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(run_tor_main_loop+0xce) [0x56404d22188e] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(threadpool_new+0x295) [0x56404d3e28f5] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(tor_assertion_failed_+0x148) [0x56404d2a9248] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(tor_main+0x49) [0x56404d21e179] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /builds/tpo/core/tor/build/src/app/tor(tor_run_main+0x1e5) [0x56404d221db5] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xea) [0x7f6aa3b1cd7a] (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) Warning: Bug: Tor 0.4.9.0-alpha-dev (git-4f3aafa1e422e9aa): Assertion 0 failed in threadpool_new at /builds/tpo/core/tor/src/lib/evloop/workqueue.c:641: . Stack trace: (on Tor 0.4.9.0-alpha-dev 4f3aafa1e422e9aa) We are figuring it out but revert this so we can release an alpha.
2024-12-03Rework of worker threads' start and exit + slight changes in cleanup codeWaldemar Zimpel
See issue #40991
2024-10-31Merge branch 'maint-0.4.8'David Goulet
2024-10-31Fix: Use FREE_AND_NULL() for releasing workqueue resourcesWaldemar Zimpel
See issue #40989
2024-10-24whitespace fix while debugging #40981Roger Dingledine
2024-10-24Merge branch 'maint-0.4.8'David Goulet
2024-10-24fallbackdir: Update list generated on October 24, 2024Tor CI Release
2024-10-24Update geoip files to match ipfire location db, 2024/10/24.Tor CI Release
2024-10-21Revert "Handle empty DNS reply without error as NOERROR"David Goulet
Closes #40984 This reverts commit 3d2f7c3467e7aff545d8e22ffd4153d7598c6d7c.
2024-10-16Merge branch 'maint-0.4.8'David Goulet
2024-10-15don't build preemptive conflux circuits if no predicted portsRoger Dingledine
Conflux circuit building was ignoring the "predicted ports" feature, which aims to make Tor stop building circuits if there have been no user requests lately. This bug led to every idle Tor on the network building and discarding circuits every 30 seconds, which added overall load to the network, used bandwidth and battery from clients that weren't actively using their Tor, and kept sockets open on guards which added connection padding essentially forever. Bug went in on commit 39c2927d when we added preemptive conflux circuit pools. Fixes bug 40981; bugfix on 0.4.8.1-alpha.
2024-10-13Create socket with correct family as given by sockshostDaniel Winzen
2024-10-10Merge branch 'maint-0.4.8'David Goulet
2024-10-10Fix: Memory leaks in cpuworker on shutdownWaldemar Zimpel
Resources allocated by cpuworker weren't being freed on clean shutdown. This applies for worker threads, worker thread pool, reply queue, reply event, ...
2024-10-10Merge branch 'empty-dns' into 'main'David Goulet
Handle empty DNS reply without error as NOERROR Closes #40248 See merge request tpo/core/tor!830
2024-09-24Fix unit test in test_entrynodes.cCecylia Bocovich
2024-09-24Handle empty DNS reply without error as NOERRORDaniel Winzen
2024-09-10Merge branch 'typo-socks-proxy' into 'main'David Goulet
Fix a typo in the HTTP proxy error message. See merge request tpo/core/tor!829
2024-09-10test: Add unit tests for prop351David Goulet
Signed-off-by: David Goulet <dgoulet@torproject.org>
2024-09-10Fix a typo in the HTTP proxy error message.Pier Angelo Vendrame
2024-09-09Implement proposal 351Nick Mathewson
This proposal adds new syntax to the SOCKS5 username/password extension scheme, so that requests with usernames starting with <torS0X> are now reserved. For C tor, all we need to do is reject every username starting with <torS0X> unless it is exactly "<torS0X>0".
2024-08-05Merge branch 'maint-0.4.8'David Goulet
2024-08-05dirvote: Fix memleak when computing consensusDavid Goulet
Fixes #40966 Signed-off-by: David Goulet <dgoulet@torproject.org>
2024-06-26Do not publish TAP key when publish-dummy-tap-key is 0.Nick Mathewson
2024-06-26Update supported protovers for prop350Nick Mathewson
Relay=1 is no longer supported; it corresponds to TAP. Microdesc=3 and Desc=3 are now supported; they correspond to the ability to handle (micro)descriptors without TAP onion keys.
2024-06-26Add a test for parsing a routerdesc with no TAP key.Nick Mathewson
2024-06-26Add a test for a microdesc with no onion key.Nick Mathewson
2024-06-26Remove a now-unused variable.Nick Mathewson
2024-06-26process_descs: Authorities require TAP keys for now.Nick Mathewson
2024-06-26Routerparse: accept routerdescs without TAP keys.Nick Mathewson
2024-06-26routerparse: Simplify checking for now-mandatory elementsNick Mathewson
All of these elements are now mandatory, so we can now simplify our logic for making sure that they are all present or all not-present.
2024-06-26Rename "onion_pkey" fields in routerinfo_t, and make them optional.Nick Mathewson
(Renaming them has forced me to look at every place where they are used, so I can make sure that they are really optional now.)
2024-06-26Remove node_get_rsa_onion_keyNick Mathewson
2024-06-26Remove TAP key from extend_info_tNick Mathewson
2024-06-24Make onion-key body optional in microdescsNick Mathewson
Also, stop storing onion keys in microdesc_t. (In prop350, for microdescs, we are making the body optional; the "onion-key" entry is still mandatory, so that we can tell where microdescs begin.)
2024-06-24Remove support for deciding to use CREATE/EXTEND/TAP.Nick Mathewson
2024-06-24prop350: Remove all support for TAP, CREATE, and EXTEND.Nick Mathewson
2024-06-24prop350: Stop accepting CREATE and EXTEND.Nick Mathewson
2024-06-18Merge branch 'maint-0.4.8'David Goulet
2024-06-18bridge: Always put transport-info lineDavid Goulet
Signed-off-by: David Goulet <dgoulet@torproject.org>
2024-06-18Clean-up Managed Proxy state in PT tests.Alexander Færøy
This patch makes sure we clean up our version and implementation fields in our Managed Proxy struct after each test run. This was detected by LeakSanitizer. See: tpo/core/tor#11101.
2024-06-18Add changes file for tpo/core/tor#11101.Alexander Færøy
2024-06-18Add implementation and version metadata to bridge extra-info.Alexander Færøy
This patch adds two new keys to bridges' extra-info document: "transport-version" and "transport-implementation". These two new values always appear together (if one is missing, the other one will be missing too) and is parsed from PT's STATUS TYPE=version messages. See: tpo/core/tor#11101.
2024-06-18Include "IMPLEMENTATION" parameter to STATUS TYPE=version PT messages.Alexander Færøy
2024-06-18Drop requirement for TRANSPORT being present in STATUS messages.Alexander Færøy
2024-06-18Add support for PT STATUS TYPE=version messages.Alexander Færøy
This patch adds support for handling the version status message. Once we receive such message, we add the given version string to the managed_proxy_t instance. Note this value can be NULL and the value can change throughout the lifetime of the PT as multiple status version messages are handled. See: tpo/core/tor#11101
2024-06-07fix sandbox for bandwidth authorityPeter Palfrader
2024-06-06Merge branch 'maint-0.4.8'David Goulet
2024-06-06fallbackdir: Update list generated on June 06, 2024Tor CI Release