aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-03-28Begin an 0.2.9 branchtor-0.2.9.0-rootNick Mathewson
2016-03-28and NOW the version is 0.2.8.2-alpha-devNick Mathewson
2016-03-28Bump version correctly this timeNick Mathewson
2016-03-28Fix memory leaks that stopped chutney working with asanNick Mathewson
2016-03-28Fix a memory leak in tor-gencert.Nick Mathewson
This way I can run chutney under asan. Fixes part of 18672.
2016-03-28Bump the version numberNick Mathewson
2016-03-28One more test that didnt pass on windows. See #18665.Nick Mathewson
2016-03-28Fix memory-counting error in rephist.c. Bug 18651. (Now with actual patch)Nick Mathewson
2016-03-26Do not treat "DOCDOC" as doxygen.Nick Mathewson
2016-03-26add a little documentation to memarea. (I have been testing a tool.)Nick Mathewson
2016-03-26Whitespace fixesNick Mathewson
2016-03-26Fix all doxygen warnings (other than missing docs)Nick Mathewson
2016-03-26Merge branch 'bug18649_squashed'Nick Mathewson
2016-03-26Clarify excess consensus connection cleanup by adding commentsteor (Tim Wilson-Brown)
Comment-only change
2016-03-25Disable failing broken time format case for windows.Nick Mathewson
2016-03-25Merge remote-tracking branch 'arma/bug18625'Nick Mathewson
2016-03-25Only check in-boundsness of seconds when time_t is smaller than i64Nick Mathewson
Otherwise coverity complains that we're checking an whether an int64 is less than INT64_MIN, which of course it isn't. Fixes CID 1357176. Not in any released Tor.
2016-03-24use a clearer argument for connection_ap_make_link()Roger Dingledine
that function calls it argument "want_onehop", so it makes more sense to pass that boolean into it.
2016-03-24remove the extraneous dir_port variableRoger Dingledine
we already are using "port" to describe the place we're going to ask to connect to.
2016-03-24remove a redundant check about whether dirport is 0Roger Dingledine
2016-03-24revert the or_connection and dir_connection flagsRoger Dingledine
They incorrectly summarized what the function was planning to do, leading to wrong behavior like making an http request to an orport, or making a begindir request to a dirport. This change backs out some of the changes made in commit e72cbf7a, and most of the changes made in commit ba6509e9. This patch resolves bug 18625. There more changes I want to make after this one, for code clarity.
2016-03-24Merge remote-tracking branch 'dgoulet/bug18623_028_01'Nick Mathewson
2016-03-24Fix broken directory request to the DirPortDavid Goulet
Commit e72cbf7a4 introduced a change to directory_initiate_command_rend() that made tor use the ORPort when making a directory request to the DirPort. The primary consequence was that a relay couldn't selftest its DirPort thus failing to work and join the network properly. The main issue was we were always considering an anonymized connection to be an OR connection which is not true. Fixes #18623 Signed-off-by: David Goulet <dgoulet@ev0ke.net>
2016-03-24try to fix a test failure for sizeof(time_t)==4.Nick Mathewson
2016-03-24Merge branch 'timegm_overflow_squashed'Nick Mathewson
2016-03-24Add a missing UL on a long in a unit testteor (Tim Wilson-Brown)
2016-03-24Add unit tests with dates from 2035 to 2039teor (Tim Wilson-Brown)
Platforms with 32-bit time_t sometimes give different results. They don't always indicate failure on overflow, #18480 should fix these.
2016-03-24Avoid overflow in tor_timegm on 32 bit platforms due to year 2038teor (Tim Wilson-Brown)
2016-03-24Merge branch 'bug18517_squashed'Nick Mathewson
2016-03-24Always allow OR connections to bridges on private addressesteor (Tim Wilson-Brown)
Regardless of the setting of ExtendAllowPrivateAddresses. This fixes a bug with pluggable transports that ignore the (potentially private) address in their bridge line. Fixes bug 18517; bugfix on 23b088907f in tor-0.2.8.1-alpha.
2016-03-24Merge remote-tracking branch 'teor/bug18351'Nick Mathewson
2016-03-24Merge remote-tracking branch 'teor/bug18489'Nick Mathewson
2016-03-24Check if fallbacks support extrainfo descriptors before requesting themteor (Tim Wilson-Brown)
When requesting extrainfo descriptors from a trusted directory server, check whether it is an authority or a fallback directory which supports extrainfo descriptors. Fixes bug 18489; bugfix on 90f6071d8d in tor-0.2.4.7-alpha. Reported by "atagar", patch by "teor".
2016-03-24Code indentation whitespace-only fixteor (Tim Wilson-Brown)
2016-03-24Clarify ReachableAddress log messagesteor (Tim Wilson-Brown)
Make it clearer that they are about outgoing connection attempts. Specify the options involved where they were missing from one log message. Clarify a comment.
2016-03-24Downgrade IP version warnings to avoid filling logsteor (Tim Wilson-Brown)
Downgrade logs and backtraces about IP versions to info-level. Only log backtraces once each time tor runs. Assists in diagnosing bug 18351; bugfix on c3cc8e16e in tor-0.2.8.1-alpha. Reported by "sysrqb" and "Christian", patch by "teor".
2016-03-22Repair build when no sandbox support is enabled.Nick Mathewson
2016-03-22Merge remote-tracking branch 'public/bug18253'Nick Mathewson
2016-03-22Try to fix an intermittent test failure on openbsd.Nick Mathewson
2016-03-22Never use sprintf. tor_snprintf instead. Bug in tests, not in any released tor.Nick Mathewson
2016-03-22Fix an fd leak in check_private_dir().Nick Mathewson
The fd would leak when the User wasn't recogniezed by getpwnam(). Since we'd then go on to exit, this wasn't a terribad leak, but it's still not as nice as no leak at all. CID 1355640; bugfix on no released Tor.
2016-03-21remove extraneous breaksRoger Dingledine
commit edeba3d4 removed a switch, but left the "break" lines in from that switch. fortunately the resulting behavior was not wrong, since there was an outer switch that it was ok to break from.
2016-03-21fix indentation after #18332 patchesRoger Dingledine
no actual changes here -- but the new indenting makes it clear that the fixes in #18332 were not as good as they should have been. the next commit will deal with that.
2016-03-21Merge branch 'maint-0.2.7'Nick Mathewson
2016-03-21Merge branch 'ed25519_voting_fixes_squashed' into maint-0.2.7Nick Mathewson
2016-03-21Use nth consistently in dircollate.h.Nick Mathewson
Documentation-only patch. Issue 17668.T6.
2016-03-21In routers_make_ed_keys_unique, break ties for published_onNick Mathewson
This ensures that if we can't use published_on to decide an ed,rsa mapping, we at least decide deterministically. Resolves 17668.T3
2016-03-21Assert that dircollator is collated when we're reading its output.Nick Mathewson
Fix for 17668.S2.
2016-03-21After we strip out duplicate entries from 'routers', don't use 'rl'.Nick Mathewson
We've got to make sure that every single subsequent calculation in dirserv_generate_networkstatus_vote_obj() are based on the list of routerinfo_t *after* we've removed possible duplicates, not before. Fortunately, none of the functions that were taking a routerlist_t as an argument were actually using any fields other than this list of routers. Resolves issue 18318.DG3.
2016-03-21Fix another case of 17668: Add NoEdConsensusNick Mathewson
I had a half-built mechanism to track, during the voting process, whether the Ed25519 value (or lack thereof) reflected a true consensus among the authorities. But we never actually inserted this field in the consensus. The key idea here is that we first attempt to match up votes by pairs of <Ed,RSA>, where <Ed> can be NULL if we're told that there is no Ed key. If this succeeds, then we can treat all those votes as 'a consensus for Ed'. And we can include all other votes with a matching RSA key and no statement about Ed keys as being "also about the same relay." After that, we look for RSA keys we haven't actually found an entry for yet, and see if there are enough votes for them, NOT considering Ed keys. If there are, we match them as before, but we treat them as "not a consensus about ed". When we include an entry in a consensus, if it does not reflect a consensus about ed keys, then we include a new NoEdConsensus flag on it. This is all only for consensus method 22 or later. Also see corresponding dir-spec patch.