aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2023-11-22 15:01:03 +0000
committerDavid Goulet <dgoulet@torproject.org>2023-11-22 15:01:03 +0000
commit0ea2e15d84c375a36b9f6a471b21ca6537f78fc3 (patch)
treef4d4695d940711b81bbd8a47017e918193fc413b /src
parent45c1a36acb0c859d647014d2d41b8497ecebcc14 (diff)
parent0be627890cf43528cee90c0d216984279187922d (diff)
downloadtor-0ea2e15d84c375a36b9f6a471b21ca6537f78fc3.tar.gz
tor-0ea2e15d84c375a36b9f6a471b21ca6537f78fc3.zip
Merge branch 'did-sanity-memmem' into 'main'
add sanity check in tor_memmem Closes #40854 See merge request tpo/core/tor!785
Diffstat (limited to 'src')
-rw-r--r--src/lib/string/util_string.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/string/util_string.c b/src/lib/string/util_string.c
index b1c0a11439..60b5933e4d 100644
--- a/src/lib/string/util_string.c
+++ b/src/lib/string/util_string.c
@@ -31,6 +31,8 @@ tor_memmem(const void *_haystack, size_t hlen,
{
#if defined(HAVE_MEMMEM) && (!defined(__GNUC__) || __GNUC__ >= 2)
raw_assert(nlen);
+ if (nlen > hlen)
+ return NULL;
return memmem(_haystack, hlen, _needle, nlen);
#else
/* This isn't as fast as the GLIBC implementation, but it doesn't need to