diff options
| author | teor <teor@torproject.org> | 2019-03-09 10:50:07 +1000 |
|---|---|---|
| committer | teor <teor@torproject.org> | 2019-03-09 11:59:52 +1000 |
| commit | 9400da9b5e44bfce0684a3b36edb37465be514d6 (patch) | |
| tree | 225a19812f54374069aa0b45cff53cf132ab2459 /src/test/test_shared_random.c | |
| parent | 2e74edb53ef9ac417d8424a0785af839f83791ca (diff) | |
| download | tor-9400da9b5e44bfce0684a3b36edb37465be514d6.tar.gz tor-9400da9b5e44bfce0684a3b36edb37465be514d6.zip | |
test/sr: Free SRVs before replacing them in test_sr_setup_srv()
Stop leaking parts of the shared random state in the shared-random unit
tests. The previous fix in 29599 was incomplete.
Fixes bug 29706; bugfix on 0.2.9.1-alpha.
Diffstat (limited to 'src/test/test_shared_random.c')
| -rw-r--r-- | src/test/test_shared_random.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index cebe772d94..0a3c2e119b 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -461,6 +461,8 @@ test_sr_setup_srv(int also_current) "ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ", sizeof(srv->value)); + /* sr_state_set_previous_srv() does not free() the old previous srv. */ + state_del_previous_srv(); sr_state_set_previous_srv(srv); if (also_current) { @@ -470,6 +472,8 @@ test_sr_setup_srv(int also_current) "NNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNN", sizeof(srv->value)); + /* sr_state_set_previous_srv() does not free() the old current srv. */ + state_del_current_srv(); sr_state_set_current_srv(srv); } } |