diff options
author | Jim Newsome <jnewsome@torproject.org> | 2024-03-07 12:32:02 -0600 |
---|---|---|
committer | Jim Newsome <jnewsome@torproject.org> | 2024-03-07 12:39:40 -0600 |
commit | 4fc43ebdeefb2baef3908ddedc41e76c40359759 (patch) | |
tree | ef235d0254ece7e6651bd14abb2481971b61fe03 /src/test/test_sandbox.c | |
parent | a5d53ce4164bd8a2070435dd7887bdfd0b5480dd (diff) | |
download | tor-4fc43ebdeefb2baef3908ddedc41e76c40359759.tar.gz tor-4fc43ebdeefb2baef3908ddedc41e76c40359759.zip |
In router_is_active, don't require non-zero bandwidthcapacity
This check was originally added in 962765a3, with the intent of
preventing relays with 0 measured bandwidth from being listed in the
consensus (part of fixing #13000).
Currently, that decision and other relevant places effectively use
`dirserv_get_credible_bandwidth_kb`, which prefers bwauth-measured
bandwidth over the self-reported `bandwidthcapacity`, making this check
mostly redundant.
i.e. this change should only affect behavior when the relay has uploaded
a descriptor with `bandwidthcapacity=0` *and* we have a non-zero
measured bandwidth, in which case we'll still trust the measured
bandwidth. This is what we want when bootstrapping a network (e.g. for
testing), since it allows us to initialize bandwidths using a bandwidth
authority file.
A relay can still cause `router_is_active` to return false by setting
the hibernate flag.
Also see discussion in #40917.
Fixes #40917.
Diffstat (limited to 'src/test/test_sandbox.c')
0 files changed, 0 insertions, 0 deletions