aboutsummaryrefslogtreecommitdiff
path: root/src/test/test_hs_service.c
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2018-09-10 10:22:31 -0400
committerDavid Goulet <dgoulet@torproject.org>2018-09-10 10:22:31 -0400
commit064d3e7497216c78b05ccd30422dc522bc337db8 (patch)
tree4d74c026c383d54efa63f44d5dac056960ce07a0 /src/test/test_hs_service.c
parent58d74ad943ee3e2d428b17fd08c2de1a093f6a27 (diff)
downloadtor-064d3e7497216c78b05ccd30422dc522bc337db8.tar.gz
tor-064d3e7497216c78b05ccd30422dc522bc337db8.zip
test: Fix coverity CID 1439130
Trivial fix of removing an uneeded NULL check in an HS v3 unit test. Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'src/test/test_hs_service.c')
-rw-r--r--src/test/test_hs_service.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c
index 6a061eaea4..bceeafd149 100644
--- a/src/test/test_hs_service.c
+++ b/src/test/test_hs_service.c
@@ -563,9 +563,7 @@ test_load_keys_with_client_auth(void *arg)
} SMARTLIST_FOREACH_END(pubkey_b32);
done:
- if (pubkey_b32_list) {
- SMARTLIST_FOREACH(pubkey_b32_list, char *, s, tor_free(s));
- }
+ SMARTLIST_FOREACH(pubkey_b32_list, char *, s, tor_free(s));
smartlist_free(pubkey_b32_list);
tor_free(hsdir_v3);
hs_free_all();