aboutsummaryrefslogtreecommitdiff
path: root/src/test/test_consdiffmgr.c
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2017-04-16 11:28:25 -0400
committerNick Mathewson <nickm@torproject.org>2017-04-24 11:01:40 -0400
commit605bcfbf711291d154c69e27fc49e3162cf4d7d0 (patch)
treed14c5a276e98be6eb32c864e31fc7d66cb81487a /src/test/test_consdiffmgr.c
parent7ca86b9cd65ba4c7ed3c36f0c56c97ad4b075585 (diff)
downloadtor-605bcfbf711291d154c69e27fc49e3162cf4d7d0.tar.gz
tor-605bcfbf711291d154c69e27fc49e3162cf4d7d0.zip
consdiffmgr: Enable in-progress test that was not previously working
Also, add a list of additional tests to write.
Diffstat (limited to 'src/test/test_consdiffmgr.c')
-rw-r--r--src/test/test_consdiffmgr.c14
1 files changed, 11 insertions, 3 deletions
diff --git a/src/test/test_consdiffmgr.c b/src/test/test_consdiffmgr.c
index 5161587873..e637c11c47 100644
--- a/src/test/test_consdiffmgr.c
+++ b/src/test/test_consdiffmgr.c
@@ -280,13 +280,10 @@ test_consdiffmgr_make_diffs(void *arg)
consdiffmgr_rescan();
tt_ptr_op(NULL, OP_NE, fake_cpuworker_queue);
tt_int_op(1, OP_EQ, smartlist_len(fake_cpuworker_queue));
- // XXXX not working yet
- /*
diff_status = consdiffmgr_find_diff_from(&diff, FLAV_MICRODESC,
DIGEST_SHA3_256,
md_ns_sha3, DIGEST256_LEN);
tt_int_op(CONSDIFF_IN_PROGRESS, OP_EQ, diff_status);
- */
// Now run that process and get the diff.
r = mock_cpuworker_run_work();
@@ -584,6 +581,17 @@ struct testcase_t consdiffmgr_tests[] = {
TEST(cleanup_no_valid_after),
TEST(cleanup_old_diffs),
+ // XXXX Test: Look up consensuses by digest in existing cases.
+ // XXXX Test: no duplicate diff job is launched when a job is pending.
+ // XXXX Test: register status when no pending entry existed?? (bug)
+ // XXXX Test: lookup entry, find in-progress.
+ // XXXX Test: lookup entry, find error.
+ // XXXX Test: clean up hashtable after most-recent-consensus changes.
+ // XXXX Test: cdm_entry_get_sha3_value cases.
+ // XXXX Test: sha3 mismatch on validation
+ // XXXX Test: initial loading of diffs from disk.
+ // XXXX Test: non-cacheing cases of replyfn().
+ // (Bug: must release handle)
END_OF_TESTCASES
};