diff options
| author | Nick Mathewson <nickm@torproject.org> | 2007-05-24 18:12:52 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2007-05-24 18:12:52 +0000 |
| commit | a312afd67ed94422c1e23d67483ed6b67c39da28 (patch) | |
| tree | 287217c562963ad7fec78ed04bdae47802806ff8 /src/or/dns.c | |
| parent | 56aefe8d2389b26b103b8522d75148e4d65d2cc4 (diff) | |
| download | tor-a312afd67ed94422c1e23d67483ed6b67c39da28.tar.gz tor-a312afd67ed94422c1e23d67483ed6b67c39da28.zip | |
r12936@catbus: nickm | 2007-05-24 14:12:34 -0400
Review XXXX comments without a version; upgrade some to XXXX020.
svn:r10315
Diffstat (limited to 'src/or/dns.c')
| -rw-r--r-- | src/or/dns.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/or/dns.c b/src/or/dns.c index 588389ae18..faf6e460a1 100644 --- a/src/or/dns.c +++ b/src/or/dns.c @@ -565,6 +565,8 @@ dns_resolve(edge_connection_t *exitconn) // If it's marked for close, it's on closeable_connection_lst in // main.c. If it's on the closeable list, it will get freed from // main.c. -NM + // "<armadev> If that's true, there are other bugs arond, where we + // don't check if it's marked, and will end up double-freeing." } break; default: @@ -814,6 +816,7 @@ dns_cancel_pending_resolve(const char *address) if (!resolve->pending_connections) { /* XXX this should never trigger, but sometimes it does */ + /* XXXX020 is the above still true? -NM */ log_warn(LD_BUG, "Address %s is pending but has no pending connections!", escaped_safe_str(address)); @@ -940,7 +943,7 @@ dns_found_answer(const char *address, int is_reverse, uint32_t addr, assert_resolve_ok(resolve); if (resolve->state != CACHE_STATE_PENDING) { - /* XXXX Maybe update addr? or check addr for consistency? Or let + /* XXXX020 Maybe update addr? or check addr for consistency? Or let * VALID replace FAILED? */ int is_test_addr = is_test_address(address); if (!is_test_addr) |