diff options
author | Roger Dingledine <arma@torproject.org> | 2017-05-10 03:11:29 -0400 |
---|---|---|
committer | Roger Dingledine <arma@torproject.org> | 2017-05-10 03:11:29 -0400 |
commit | 0266c4ac819d9c835a77a0c1e0334f26f60f6f77 (patch) | |
tree | 28143b856dfa25188d75cbb935494949217c09d7 /src/or/dirserv.c | |
parent | 9f5b71a7cafbaf1468ec9cb72b8061343c1fae98 (diff) | |
download | tor-0266c4ac819d9c835a77a0c1e0334f26f60f6f77.tar.gz tor-0266c4ac819d9c835a77a0c1e0334f26f60f6f77.zip |
add an XXX with a minor bug in dirserv_add_multiple_descriptors
Diffstat (limited to 'src/or/dirserv.c')
-rw-r--r-- | src/or/dirserv.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 7de72df9eb..c25dbf8420 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -571,6 +571,8 @@ dirserv_add_multiple_descriptors(const char *desc, uint8_t purpose, !general ? router_purpose_to_string(purpose) : "", !general ? "\n" : "")<0) { *msg = "Couldn't format annotations"; + /* XXX Not cool: we return -1 below, but (was_router_added_t)-1 is + * ROUTER_BAD_EI, which isn't what's gone wrong here. :( */ return -1; } |