aboutsummaryrefslogtreecommitdiff
path: root/src/feature
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2020-10-19 11:45:24 -0400
committerNick Mathewson <nickm@torproject.org>2020-10-19 11:45:24 -0400
commitcb4cedae686bd227d42997840b3a6b0b3bc5e936 (patch)
tree579d5d6a89e8bfdea5a11935eaa355752f51dba6 /src/feature
parent781ab9eea49b07b1925d7d8dcbad06348896344e (diff)
downloadtor-cb4cedae686bd227d42997840b3a6b0b3bc5e936.tar.gz
tor-cb4cedae686bd227d42997840b3a6b0b3bc5e936.zip
Explain why we use "mark_as_used_for_origin_circuit" where we do
Also, explain why it's relevant for bootstrapping. This is a comments-only patch.
Diffstat (limited to 'src/feature')
-rw-r--r--src/feature/control/control_bootstrap.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/src/feature/control/control_bootstrap.c b/src/feature/control/control_bootstrap.c
index cca2a81b1f..d6dfdad94e 100644
--- a/src/feature/control/control_bootstrap.c
+++ b/src/feature/control/control_bootstrap.c
@@ -348,8 +348,17 @@ control_event_bootstrap_prob_or, (const char *warn, int reason,
{
int dowarn = 0;
- if (! or_conn->potentially_used_for_bootstrapping)
+ if (! or_conn->potentially_used_for_bootstrapping) {
+ /* We never decided that this channel was a good match for one of our
+ * origin_circuit_t objects. That means that we probably launched it
+ * for somebody else, most likely in response to an EXTEND cell.
+ *
+ * Since EXTEND cells can contain arbitrarily broken descriptions of
+ * relays, a failure on this connection here won't necessarily indicate a
+ * bootstrapping problem.
+ */
return;
+ }
if (or_conn->have_noted_bootstrap_problem)
return;