diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-04-11 18:38:59 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-04-11 18:41:38 -0400 |
| commit | 96e310911fa14b8a8fb1861d08fbda7abe61eb10 (patch) | |
| tree | 2acddc320534a0d32bce3b6d3faa3fa974596227 /src/feature/nodelist/node_select.c | |
| parent | 55690d05bd8856798d2e6f6b56261629847c068b (diff) | |
| download | tor-96e310911fa14b8a8fb1861d08fbda7abe61eb10.tar.gz tor-96e310911fa14b8a8fb1861d08fbda7abe61eb10.zip | |
Add an assertion to compute_weighted_bandwidths()
This should please coverity, and fix CID 1415722. It didn't
understand that networkstatus_get_param() always returns a value
between its minimum and maximum values.
Diffstat (limited to 'src/feature/nodelist/node_select.c')
| -rw-r--r-- | src/feature/nodelist/node_select.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/feature/nodelist/node_select.c b/src/feature/nodelist/node_select.c index e31abb247f..93ddb066d4 100644 --- a/src/feature/nodelist/node_select.c +++ b/src/feature/nodelist/node_select.c @@ -585,6 +585,7 @@ compute_weighted_bandwidths(const smartlist_t *sl, } weight_scale = networkstatus_get_weight_scale_param(NULL); + tor_assert(weight_scale >= 1); if (rule == WEIGHT_FOR_GUARD) { Wg = networkstatus_get_bw_weight(NULL, "Wgg", -1); |