aboutsummaryrefslogtreecommitdiff
path: root/src/core/or/protover.c
diff options
context:
space:
mode:
authorcypherpunks <cypherpunks@torproject.org>2018-08-17 22:45:33 +0000
committercypherpunks <cypherpunks@torproject.org>2020-02-09 01:24:47 +0000
commit32b33c0d21ce471d735abbedc26d26998238c380 (patch)
tree0a07cd6f007812c6f22422ad4d3894d77c00fc04 /src/core/or/protover.c
parentc2b95da4d49504281f7c30c8f523cd492be932a7 (diff)
downloadtor-32b33c0d21ce471d735abbedc26d26998238c380.tar.gz
tor-32b33c0d21ce471d735abbedc26d26998238c380.zip
protover: reject unexpected commas
Consistently reject extra commas, instead of only rejecting leading commas. Fix on b2b2e1c7f24d9b65059e3d089768d6c49ba4f58f. Fixes #27194; bugfix on 0.2.9.4-alpha.
Diffstat (limited to 'src/core/or/protover.c')
-rw-r--r--src/core/or/protover.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/core/or/protover.c b/src/core/or/protover.c
index 17979d04ea..763eadadf9 100644
--- a/src/core/or/protover.c
+++ b/src/core/or/protover.c
@@ -245,7 +245,8 @@ parse_single_entry(const char *s, const char *end_of_entry)
}
s = comma;
- while (*s == ',' && s < end_of_entry)
+ // Skip the comma separator between ranges. Don't ignore a trailing comma.
+ if (s < (end_of_entry - 1))
++s;
}