aboutsummaryrefslogtreecommitdiff
path: root/src/core/or/connection_edge.c
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2021-10-08 10:43:53 -0400
committerDavid Goulet <dgoulet@torproject.org>2021-10-08 10:43:53 -0400
commitba5a71b91325b52f27fff76b736af9ddd16ba540 (patch)
tree986dc109ffaeb1e2accd757d90e807ab7fcae398 /src/core/or/connection_edge.c
parentfd5e9f4041f2f648fd9c94ce8b742e5c54644323 (diff)
parent4046b9f3ee996258e2335c64e7b914df7185ffc9 (diff)
downloadtor-ba5a71b91325b52f27fff76b736af9ddd16ba540.tar.gz
tor-ba5a71b91325b52f27fff76b736af9ddd16ba540.zip
Merge branch 'tor-gitlab/mr/447'
Diffstat (limited to 'src/core/or/connection_edge.c')
-rw-r--r--src/core/or/connection_edge.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c
index f3c1ca3dab..7127cbb94b 100644
--- a/src/core/or/connection_edge.c
+++ b/src/core/or/connection_edge.c
@@ -1347,11 +1347,10 @@ connection_ap_attach_pending(int retry)
continue;
}
if (conn->state != AP_CONN_STATE_CIRCUIT_WAIT) {
- log_warn(LD_BUG, "%p is no longer in circuit_wait. Its current state "
- "is %s. Why is it on pending_entry_connections?",
- entry_conn,
- conn_state_to_string(conn->type, conn->state));
- UNMARK();
+ /* The connection_ap_handshake_attach_circuit() call, for onion service,
+ * can lead to more than one connections in the "pending" list to change
+ * state and so it is OK to get here. Ignore it because this connection
+ * won't be in pending_entry_connections list after this point. */
continue;
}