aboutsummaryrefslogtreecommitdiff
path: root/src/core/or/connection_edge.c
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2019-06-28 11:27:59 -0400
committerNick Mathewson <nickm@torproject.org>2019-06-28 11:29:51 -0400
commit0fa3dc3228a32fd21ff71e24e3c2e456e342e3b8 (patch)
tree2f7fa42644abbe27abe7b0a27198fe22ef217772 /src/core/or/connection_edge.c
parentc34a6b922f3e5ff22c99c70bfe3832b647ce5b49 (diff)
downloadtor-0fa3dc3228a32fd21ff71e24e3c2e456e342e3b8.tar.gz
tor-0fa3dc3228a32fd21ff71e24e3c2e456e342e3b8.zip
begin_cell_parse(): Add an assertion to please coverity.
Coverity doesn't understand that if begin_cell_parse() returns 0 and sets is_begindir to 0, its address field will always be set. Fixes bug 30126; bugfix on 0.2.4.7-alpha; Fixes CID 1447296.
Diffstat (limited to 'src/core/or/connection_edge.c')
-rw-r--r--src/core/or/connection_edge.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c
index c08d2a9ff5..091d9c9b09 100644
--- a/src/core/or/connection_edge.c
+++ b/src/core/or/connection_edge.c
@@ -3833,6 +3833,7 @@ connection_exit_begin_conn(cell_t *cell, circuit_t *circ)
if (! bcell.is_begindir) {
/* Steal reference */
+ tor_assert(bcell.address);
address = bcell.address;
port = bcell.port;