diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-11-22 09:04:36 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-11-22 09:04:36 -0500 |
| commit | ff7d0ebcfe54223e092bfb8c4f9e6b11c5ef6627 (patch) | |
| tree | 4aad5ad72aaef5bc6f25ee415159dc1ceb562440 /src/app | |
| parent | cf22841e3bf45a8b73900dd480022f1722d3b557 (diff) | |
| download | tor-ff7d0ebcfe54223e092bfb8c4f9e6b11c5ef6627.tar.gz tor-ff7d0ebcfe54223e092bfb8c4f9e6b11c5ef6627.zip | |
Fix a low-impact memory leak in options_act_reversible()
Found by Coverity as CID 1455953
Fixes bug 32575; bug not in any released Tor.
Diffstat (limited to 'src/app')
| -rw-r--r-- | src/app/config/config.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/app/config/config.c b/src/app/config/config.c index e61281dac8..34f20c31c8 100644 --- a/src/app/config/config.c +++ b/src/app/config/config.c @@ -1945,7 +1945,7 @@ options_act_reversible,(const or_options_t *old_options, char **msg)) if (first_time) { if (options_switch_id(msg) < 0) - goto done; + goto rollback; } /* On the other hand, we need to touch the file system _after_ we @@ -1954,7 +1954,7 @@ options_act_reversible,(const or_options_t *old_options, char **msg)) */ if (first_time) { if (options_create_directories(msg) < 0) - goto done; + goto rollback; } /* Bail out at this point if we're not going to be a client or server: |