From ff7d0ebcfe54223e092bfb8c4f9e6b11c5ef6627 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Fri, 22 Nov 2019 09:04:36 -0500 Subject: Fix a low-impact memory leak in options_act_reversible() Found by Coverity as CID 1455953 Fixes bug 32575; bug not in any released Tor. --- src/app/config/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/app') diff --git a/src/app/config/config.c b/src/app/config/config.c index e61281dac8..34f20c31c8 100644 --- a/src/app/config/config.c +++ b/src/app/config/config.c @@ -1945,7 +1945,7 @@ options_act_reversible,(const or_options_t *old_options, char **msg)) if (first_time) { if (options_switch_id(msg) < 0) - goto done; + goto rollback; } /* On the other hand, we need to touch the file system _after_ we @@ -1954,7 +1954,7 @@ options_act_reversible,(const or_options_t *old_options, char **msg)) */ if (first_time) { if (options_create_directories(msg) < 0) - goto done; + goto rollback; } /* Bail out at this point if we're not going to be a client or server: -- cgit v1.2.3-54-g00ecf