aboutsummaryrefslogtreecommitdiff
path: root/scripts/test
diff options
context:
space:
mode:
authorrl1987 <rl1987@sdf.lonestar.org>2018-11-26 18:03:36 +0200
committerrl1987 <rl1987@sdf.lonestar.org>2018-11-26 18:03:36 +0200
commit59001a69c96a2f14821d312b10482c0854c6d7dd (patch)
tree5e94b19c9f6c7ab7c66dee1e976bad817dd16ced /scripts/test
parentd6eafd06a9797d2747b0bd5988893c292076ef1f (diff)
downloadtor-59001a69c96a2f14821d312b10482c0854c6d7dd.tar.gz
tor-59001a69c96a2f14821d312b10482c0854c6d7dd.zip
Address SC2086 in scan-build.sh
We can safely silence SC2086 warning on $CHECKERS, as contents of that is hardcoded into script, and we don't want to require Bash to use Bash array here. Double-quote $OUTPUTARG, as it's value depends on environment variable.
Diffstat (limited to 'scripts/test')
-rwxr-xr-xscripts/test/scan-build.sh5
1 files changed, 4 insertions, 1 deletions
diff --git a/scripts/test/scan-build.sh b/scripts/test/scan-build.sh
index e111566bf7..9a63383804 100755
--- a/scripts/test/scan-build.sh
+++ b/scripts/test/scan-build.sh
@@ -54,6 +54,7 @@ else
OUTPUTARG=""
fi
+# shellcheck disable=SC2086
scan-build \
$CHECKERS \
./configure
@@ -63,13 +64,15 @@ scan-build \
# Make this not get scanned for dead assignments, since it has lots of
# dead assignments we don't care about.
+# shellcheck disable=SC2086
scan-build \
$CHECKERS \
-disable-checker deadcode.DeadStores \
make -j5 -k ./src/ext/ed25519/ref10/libed25519_ref10.a
+# shellcheck disable=SC2086
scan-build \
- $CHECKERS $OUTPUTARG \
+ $CHECKERS "$OUTPUTARG" \
make -j5 -k
CHECKERS="\