diff options
| author | David Goulet <dgoulet@torproject.org> | 2020-07-21 11:34:13 -0400 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2020-07-21 15:48:05 -0400 |
| commit | 803e769fb255f39dba07b5dbc2ca62a43b43004c (patch) | |
| tree | 3685a594cdc365e3bdeadafaeb3e29537cb3865a /doc/HACKING/android | |
| parent | c3a0f757964de0e8a24911d72abff5df20bb323c (diff) | |
| download | tor-803e769fb255f39dba07b5dbc2ca62a43b43004c.tar.gz tor-803e769fb255f39dba07b5dbc2ca62a43b43004c.zip | |
relay: Remove possible ORPorts duplicate from parsed list
Now that tor automatically binds to IPv4 _and_ IPv6, in order to avoid
breaking configurations, we sanitize the parsed lists for duplicate ORPorts.
It is possible to happen because we still allow this configuration;
ORPort 9888
ORPort [4242::1]:9888
Meaning that the first ORPort value will bind to 0.0.0.0:9888 _and_ [::]:9888
which would lead to an error when attempting to bind on [4242::1]:9888.
However, that configuration is accepted today and thus we must not break it.
To remedy, we now sanitize the parsed list and prioritize an ORPort that has
an explicit address over the global one.
A warning is emitted if such configuration pattern is found. This is only for
the ORPort.
Related to #33246
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'doc/HACKING/android')
0 files changed, 0 insertions, 0 deletions