diff options
| author | David Goulet <dgoulet@torproject.org> | 2023-11-07 13:50:28 -0500 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2023-11-07 13:50:28 -0500 |
| commit | e62b8bce5a88f8fa38a62ab503df7f0eecfb1d22 (patch) | |
| tree | 024232a2b14315374f0d57a631e6324b36af0224 /changes | |
| parent | c7d8501da87c6c6254880b27777cf6a15cd5484d (diff) | |
| download | tor-e62b8bce5a88f8fa38a62ab503df7f0eecfb1d22.tar.gz tor-e62b8bce5a88f8fa38a62ab503df7f0eecfb1d22.zip | |
hs: Fix assert in hs_metrics_update_by_ident()
The hs_metrics_failed_rdv() macro could pass a NULL value for the identity key
when a building circuit would end up in a failure path *before* the "hs_ident"
was able to be set which leading to this assert.
This was introduced in 0.4.8.1-alpha with the addition of rendezvous circuit
failure metrics for the MetricsPort.
This fixes TROVE-2023-006 for which its severity is considered high.
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/ticket40883 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changes/ticket40883 b/changes/ticket40883 new file mode 100644 index 0000000000..1186571122 --- /dev/null +++ b/changes/ticket40883 @@ -0,0 +1,4 @@ + o Major bugfixes (onion service, TROVE-2023-006): + - Fix a possible hard assert on a NULL pointer when recording a failed + rendezvous circuit on the service side for the MetricsPort. Fixes bug + 40883; bugfix on 0.4.8.1-alpha |