aboutsummaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2021-05-04 10:37:26 -0400
committerDavid Goulet <dgoulet@torproject.org>2021-05-04 10:37:26 -0400
commitcf6e72b7020c47ba20677dc19602663723bd8491 (patch)
treebf74b64be9a0d1798b07184703b1c565ba5a3e91 /changes
parentf0260c4cea6da784369e8d47f0b4bf01863c5af5 (diff)
downloadtor-cf6e72b7020c47ba20677dc19602663723bd8491.tar.gz
tor-cf6e72b7020c47ba20677dc19602663723bd8491.zip
hs: Fix ADD_ONION with client authorization
Turns out that passing client authorization keys to ADD_ONION for v3 was not working because we were not setting the "is_client_auth_enabled" flag to true once the clients were configured. This lead to the descriptor being encoded without the clients. This patch removes that flag and instead adds an inline function that can be used to check if a given service has client authorization enabled. This will be much less error prone of needing to keep in sync the client list and a flag instead. Fixes #40378 Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'changes')
-rw-r--r--changes/ticket403784
1 files changed, 4 insertions, 0 deletions
diff --git a/changes/ticket40378 b/changes/ticket40378
new file mode 100644
index 0000000000..35b2fd7bd4
--- /dev/null
+++ b/changes/ticket40378
@@ -0,0 +1,4 @@
+ o Major bugfixes (onion service, control port):
+ - Make the ADD_ONION command properly configure client authorization. Before
+ this fix, the created onion failed to add the client(s). Fixes bug 40378;
+ bugfix on 0.4.6.1-alpha.