aboutsummaryrefslogtreecommitdiff
path: root/changes/ticket28840
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2019-03-14 15:15:03 -0400
committerNick Mathewson <nickm@torproject.org>2019-03-25 16:35:34 -0400
commit47de9c7b0a828de7fb8129413db70bc4e4ecac6d (patch)
tree6ae05094378e3c941ceb2ff93fa5fa6db84f492d /changes/ticket28840
parent8d70f217175b69a7b8e5d35b564f50712c882d7e (diff)
downloadtor-47de9c7b0a828de7fb8129413db70bc4e4ecac6d.tar.gz
tor-47de9c7b0a828de7fb8129413db70bc4e4ecac6d.zip
Use actual pointers in dispatch_cfg.c.
Previously, I had used integers encoded as pointers. This introduced a flaw: NULL represented both the integer zero, and the absence of a setting. This in turn made the checks in cfg_msg_set_{type,chan}() not actually check for an altered value if the previous value had been set to zero. Also, I had previously kept a pointer to a dispatch_fypefns_t rather than making a copy of it. This meant that if the dispatch_typefns_t were changed between defining the typefns and creating the dispatcher, we'd get the modified version. Found while investigating coverage in pubsub_add_{pub,sub}_()
Diffstat (limited to 'changes/ticket28840')
0 files changed, 0 insertions, 0 deletions