diff options
| author | Nick Mathewson <nickm@torproject.org> | 2018-12-13 11:26:09 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2018-12-13 11:26:09 -0500 |
| commit | 041e9235c1710936a43f73d2f6e87bfc6e1c2242 (patch) | |
| tree | b7d61b884932cbc74739681852f842979dd8debc /changes/ticket28838 | |
| parent | a3fe08164758e755fb2b51c7fb96e42d96179640 (diff) | |
| download | tor-041e9235c1710936a43f73d2f6e87bfc6e1c2242.tar.gz tor-041e9235c1710936a43f73d2f6e87bfc6e1c2242.zip | |
Lower the loop_max constant in curve25519_basepoint_spot_check()
The point of this function is to make sure that the ed25519-based
implementation of curve25519_basepoint() actually works when we
start tor, and use the regular fallback implementation if it
doesn't. But it accounts for 9% of our startup time in the case
when we have directory information, and I think it's safe to make
the test shorter. After all, it has yet to find any actual bugs in
curved25519_scalarmult_basepoint_donna() on any platforms.
Closes ticket 28838.
Diffstat (limited to 'changes/ticket28838')
| -rw-r--r-- | changes/ticket28838 | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/changes/ticket28838 b/changes/ticket28838 new file mode 100644 index 0000000000..6c290bf82b --- /dev/null +++ b/changes/ticket28838 @@ -0,0 +1,8 @@ + o Minor features (performance): + - Remove about 96% of the work from the function that we run at + startup to test our curve25519_basepoint implementation. Since + this function has yet to find an actual failure, we'll only + run it for 8 iterations instead of 200. Based on our profile + information, this change should save around 8% of our startup + time on typical desktops, and may have a similar effect on + other platforms. Closes ticket 28838. |