aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2018-10-17 13:02:23 -0400
committerNick Mathewson <nickm@torproject.org>2018-10-17 13:02:23 -0400
commitb1891068f1cd1513e8ffba0be6d5ca7050f5e689 (patch)
tree0273beda1f23b2f3dcfab7edabf64804ee28b8a6
parent0ba05092ad16c37ef12db37816b06f160e4cfcb8 (diff)
parent2000d04cb67fa1ee88105e61666dceba40b8c368 (diff)
downloadtor-b1891068f1cd1513e8ffba0be6d5ca7050f5e689.tar.gz
tor-b1891068f1cd1513e8ffba0be6d5ca7050f5e689.zip
Merge branch 'maint-0.3.4'
-rw-r--r--changes/ticket280896
-rw-r--r--src/core/mainloop/connection.c2
2 files changed, 7 insertions, 1 deletions
diff --git a/changes/ticket28089 b/changes/ticket28089
new file mode 100644
index 0000000000..a900ec18f5
--- /dev/null
+++ b/changes/ticket28089
@@ -0,0 +1,6 @@
+ o Major bugfixes (relay):
+ - When our write bandwidth limit is exhausted, stop writing on the
+ connection. Previously, we had a typo in the code that would make us stop
+ reading leading to relay connections being stuck indefinitely. Fixes bug
+ 28089; bugfix on 0.3.4.1-alpha.
+
diff --git a/src/core/mainloop/connection.c b/src/core/mainloop/connection.c
index 5c0799fbe3..1198a01ad9 100644
--- a/src/core/mainloop/connection.c
+++ b/src/core/mainloop/connection.c
@@ -3308,7 +3308,7 @@ connection_write_bw_exhausted(connection_t *conn, bool is_global_bw)
{
(void)is_global_bw;
conn->write_blocked_on_bw = 1;
- connection_stop_reading(conn);
+ connection_stop_writing(conn);
reenable_blocked_connection_schedule();
}