aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2017-08-01 11:28:36 -0400
committerNick Mathewson <nickm@torproject.org>2017-08-01 11:28:36 -0400
commit8500f0e4e179280ebb8d6c1f3342eff21a4fdac2 (patch)
tree6a7cc90a555a6ce6f2ebb6ee06ea090216f2b26c
parent2b94b0ea721f2bd0127d097860ef64b915e2781a (diff)
parentec5fe41209add4b216029466774a6b7e833210ef (diff)
downloadtor-8500f0e4e179280ebb8d6c1f3342eff21a4fdac2.tar.gz
tor-8500f0e4e179280ebb8d6c1f3342eff21a4fdac2.zip
Merge remote-tracking branch 'public/bug20059_024_v2' into maint-0.2.9
-rw-r--r--changes/bug200593
-rw-r--r--src/or/onion.c4
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/bug20059 b/changes/bug20059
new file mode 100644
index 0000000000..091fab06d1
--- /dev/null
+++ b/changes/bug20059
@@ -0,0 +1,3 @@
+ o Minor bugfixes (relay):
+ - Avoid a double-marked-circuit warning that can happen when we receive
+ DESTROY cells under heavy load. Fixes bug 20059; bugfix on 0.1.0.1-rc.
diff --git a/src/or/onion.c b/src/or/onion.c
index a987883802..4b803a785c 100644
--- a/src/or/onion.c
+++ b/src/or/onion.c
@@ -235,7 +235,9 @@ onion_pending_add(or_circuit_t *circ, create_cell_t *onionskin)
onion_queue_entry_remove(head);
log_info(LD_CIRC,
"Circuit create request is too old; canceling due to overload.");
- circuit_mark_for_close(TO_CIRCUIT(circ), END_CIRC_REASON_RESOURCELIMIT);
+ if (! TO_CIRCUIT(circ)->marked_for_close) {
+ circuit_mark_for_close(TO_CIRCUIT(circ), END_CIRC_REASON_RESOURCELIMIT);
+ }
}
return 0;
}