1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
# Copyright 2015-2018 Alexander Cogneau (acogneau) <alexander.cogneau@gmail.com>:
# Copyright 2015-2021 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# SPDX-License-Identifier: GPL-3.0-or-later
from qutebrowser.qt.network import QNetworkCookie
from qutebrowser.qt.core import QUrl
import pytest
from qutebrowser.browser.webkit import cookies
from qutebrowser.utils import usertypes, urlmatch
from qutebrowser.misc import lineparser, objects
pytestmark = pytest.mark.usefixtures('data_tmpdir')
COOKIE1 = b'foo1=bar; expires=Tue, 01-Jan-2036 08:00:01 GMT'
COOKIE2 = b'foo2=bar; expires=Tue, 01-Jan-2036 08:00:01 GMT'
SESSION_COOKIE = b'foo3=bar'
EXPIRED_COOKIE = b'foo4=bar; expires=Sat, 01-Jan-2000 08:00:01 GMT'
class LineparserSaveStub(lineparser.BaseLineParser):
"""A stub for LineParser's save().
Attributes:
data: The data before the write
saved: The .data before save()
"""
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.saved = []
self.data = []
def save(self):
self.saved = self.data
def clear(self):
pass
def __iter__(self):
return iter(self.data)
def __getitem__(self, key):
return self.data[key]
class TestSetCookies:
@pytest.fixture
def cookie(self):
return QNetworkCookie(b'foo', b'bar')
@pytest.fixture
def ram_jar(self):
return cookies.RAMCookieJar()
@pytest.fixture
def url(self):
return QUrl('http://example.com/')
@pytest.fixture(autouse=True)
def set_webkit_backend(self, monkeypatch):
monkeypatch.setattr(objects, 'backend', usertypes.Backend.QtWebKit)
def test_accept(self, config_stub, qtbot, monkeypatch,
cookie, ram_jar, url):
"""Test setCookiesFromUrl with cookies enabled."""
config_stub.val.content.cookies.accept = 'all'
with qtbot.wait_signal(ram_jar.changed):
assert ram_jar.setCookiesFromUrl([cookie], url)
# assert the cookies are added correctly
all_cookies = ram_jar.cookiesForUrl(url)
assert len(all_cookies) == 1
saved_cookie = all_cookies[0]
expected = cookie.name(), cookie.value()
assert saved_cookie.name(), saved_cookie.value() == expected
def test_never_accept(self, qtbot, config_stub, monkeypatch,
cookie, ram_jar, url):
"""Test setCookiesFromUrl when cookies are not accepted."""
config_stub.val.content.cookies.accept = 'never'
with qtbot.assert_not_emitted(ram_jar.changed):
assert not ram_jar.setCookiesFromUrl([cookie], url)
assert not ram_jar.cookiesForUrl(url)
def test_per_url(self, config_stub, qtbot, monkeypatch,
cookie, ram_jar, url):
config_stub.val.content.cookies.accept = 'all'
config_stub.set_str('content.cookies.accept', 'never',
pattern=urlmatch.UrlPattern('http://example.com'))
org_url = QUrl('http://example.org/')
with qtbot.wait_signal(ram_jar.changed):
assert ram_jar.setCookiesFromUrl([cookie], org_url)
assert ram_jar.cookiesForUrl(org_url)
with qtbot.assert_not_emitted(ram_jar.changed):
assert not ram_jar.setCookiesFromUrl([cookie], url)
assert not ram_jar.cookiesForUrl(url)
def test_logging(self, monkeypatch, caplog, config_stub,
cookie, ram_jar, url):
monkeypatch.setattr(objects, 'debug_flags', ['log-cookies'])
ram_jar.setCookiesFromUrl([cookie], url)
expected = "Cookie on http://example.com/ -> applying setting all"
assert caplog.messages == [expected]
def test_cookie_jar_init(config_stub, fake_save_manager):
"""Test the CookieJar constructor."""
line_parser_stub = [COOKIE1, COOKIE2]
jar = cookies.CookieJar(line_parser=line_parser_stub)
assert fake_save_manager.add_saveable.called
# Test that cookies are added to the jar
assert len(jar.allCookies()) == 2
raw_cookies = [c.toRawForm().data() for c in jar.allCookies()]
assert raw_cookies == [COOKIE1, COOKIE2]
def test_purge_old_cookies(config_stub, fake_save_manager):
"""Test that expired cookies are deleted."""
line_parser_stub = [COOKIE1, COOKIE2, SESSION_COOKIE, EXPIRED_COOKIE]
jar = cookies.CookieJar(line_parser=line_parser_stub)
assert len(jar.allCookies()) == 4
jar.purge_old_cookies()
# Test that old cookies are gone
raw_cookies = [cookie.toRawForm().data() for cookie in jar.allCookies()]
assert raw_cookies == [COOKIE1, COOKIE2, SESSION_COOKIE]
def test_save(config_stub, fake_save_manager, monkeypatch, qapp):
"""Test that expired and session cookies are not saved."""
monkeypatch.setattr(lineparser, 'LineParser', LineparserSaveStub)
jar = cookies.CookieJar()
jar._lineparser.data = [COOKIE1, COOKIE2, SESSION_COOKIE, EXPIRED_COOKIE]
# Update the cookies on the jar itself
jar.parse_cookies()
jar.save()
saved_cookies = [cookie.data() for cookie in jar._lineparser.saved]
assert saved_cookies == [COOKIE1, COOKIE2]
def test_cookies_changed_emit(config_stub, fake_save_manager,
monkeypatch, qtbot):
"""Test that self.changed is emitted."""
monkeypatch.setattr(lineparser, 'LineParser', LineparserSaveStub)
jar = cookies.CookieJar()
with qtbot.wait_signal(jar.changed):
config_stub.val.content.cookies.store = False
@pytest.mark.parametrize('store_cookies,empty', [(True, False), (False, True)])
def test_cookies_changed(config_stub, fake_save_manager, monkeypatch, qtbot,
store_cookies, empty):
"""Test that cookies are saved correctly."""
monkeypatch.setattr(lineparser, 'LineParser', LineparserSaveStub)
jar = cookies.CookieJar()
jar._lineparser.data = [COOKIE1, COOKIE2]
jar.parse_cookies()
config_stub.val.content.cookies.store = store_cookies
if empty:
assert not jar._lineparser.data
assert not jar._lineparser.saved
else:
assert jar._lineparser.data
def test_init(qapp, config_stub, fake_save_manager):
assert cookies.cookie_jar is None
assert cookies.ram_cookie_jar is None
cookies.init(qapp)
assert isinstance(cookies.cookie_jar, cookies.CookieJar)
assert isinstance(cookies.ram_cookie_jar, cookies.RAMCookieJar)
|
