summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorAnder Punnar <ander@kvlt.ee>2021-07-20 00:12:57 +0300
committerAnder Punnar <ander@kvlt.ee>2021-07-20 00:15:40 +0300
commit036be4e410ef9faa951ef63bc868f43834dcc97b (patch)
tree9922ba07240ac5ed2cf698e371ec60cea63aa054 /tests
parent57f24e7d430c87a5f2060b2f13bdaf15b231810f (diff)
downloadqutebrowser-036be4e410ef9faa951ef63bc868f43834dcc97b.tar.gz
qutebrowser-036be4e410ef9faa951ef63bc868f43834dcc97b.zip
parametrize test_subdomain_blocking
Diffstat (limited to 'tests')
-rw-r--r--tests/unit/components/test_hostblock.py11
1 files changed, 6 insertions, 5 deletions
diff --git a/tests/unit/components/test_hostblock.py b/tests/unit/components/test_hostblock.py
index a1ae2ad5c..6a71058ea 100644
--- a/tests/unit/components/test_hostblock.py
+++ b/tests/unit/components/test_hostblock.py
@@ -565,12 +565,13 @@ def test_adblock_benchmark(data_tmpdir, benchmark, host_blocker_factory):
benchmark(lambda: blocker._is_blocked(url))
-def test_subdomain_blocking(config_stub, host_blocker_factory):
+@pytest.mark.parametrize("block_subdomains", [True, False])
+def test_subdomain_blocking(config_stub, host_blocker_factory, block_subdomains):
config_stub.val.content.blocking.method = "hosts"
config_stub.val.content.blocking.hosts.lists = None
+ config_stub.val.content.blocking.hosts.block_subdomains = block_subdomains
host_blocker = host_blocker_factory()
host_blocker._blocked_hosts.add("example.com")
- config_stub.val.content.blocking.hosts.block_subdomains = True
- assert host_blocker._is_blocked(QUrl("https://subdomain.example.com"))
- config_stub.val.content.blocking.hosts.block_subdomains = False
- assert not host_blocker._is_blocked(QUrl("https://subdomain.example.com"))
+ is_blocked = host_blocker._is_blocked(QUrl("https://subdomain.example.com"))
+ # block_subdomains is also expected result of is_blocked
+ assert is_blocked == block_subdomains