From 036be4e410ef9faa951ef63bc868f43834dcc97b Mon Sep 17 00:00:00 2001 From: Ander Punnar Date: Tue, 20 Jul 2021 00:12:57 +0300 Subject: parametrize test_subdomain_blocking --- tests/unit/components/test_hostblock.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'tests') diff --git a/tests/unit/components/test_hostblock.py b/tests/unit/components/test_hostblock.py index a1ae2ad5c..6a71058ea 100644 --- a/tests/unit/components/test_hostblock.py +++ b/tests/unit/components/test_hostblock.py @@ -565,12 +565,13 @@ def test_adblock_benchmark(data_tmpdir, benchmark, host_blocker_factory): benchmark(lambda: blocker._is_blocked(url)) -def test_subdomain_blocking(config_stub, host_blocker_factory): +@pytest.mark.parametrize("block_subdomains", [True, False]) +def test_subdomain_blocking(config_stub, host_blocker_factory, block_subdomains): config_stub.val.content.blocking.method = "hosts" config_stub.val.content.blocking.hosts.lists = None + config_stub.val.content.blocking.hosts.block_subdomains = block_subdomains host_blocker = host_blocker_factory() host_blocker._blocked_hosts.add("example.com") - config_stub.val.content.blocking.hosts.block_subdomains = True - assert host_blocker._is_blocked(QUrl("https://subdomain.example.com")) - config_stub.val.content.blocking.hosts.block_subdomains = False - assert not host_blocker._is_blocked(QUrl("https://subdomain.example.com")) + is_blocked = host_blocker._is_blocked(QUrl("https://subdomain.example.com")) + # block_subdomains is also expected result of is_blocked + assert is_blocked == block_subdomains -- cgit v1.2.3-54-g00ecf