summaryrefslogtreecommitdiff
path: root/tests/unit/utils/test_log.py
diff options
context:
space:
mode:
authorPhilipp Albrecht <palbrecht@mailbox.org>2023-07-10 10:11:51 +0200
committerPhilipp Albrecht <palbrecht@mailbox.org>2023-07-20 15:09:48 +0200
commitebfe9b7aa0c4ba9d451f993e08955004aaec4345 (patch)
treec9c21c6972f5d8f79e3558eb52ad0004771129a3 /tests/unit/utils/test_log.py
parent30570a5cad1a3e7f648f066b4a1df8158d6b1189 (diff)
downloadqutebrowser-ebfe9b7aa0c4ba9d451f993e08955004aaec4345.tar.gz
qutebrowser-ebfe9b7aa0c4ba9d451f993e08955004aaec4345.zip
Move qt_message_handler() to qtlog
I had to create `qtlog.init()` to deal with the global variable `_args`.
Diffstat (limited to 'tests/unit/utils/test_log.py')
-rw-r--r--tests/unit/utils/test_log.py28
1 files changed, 1 insertions, 27 deletions
diff --git a/tests/unit/utils/test_log.py b/tests/unit/utils/test_log.py
index 51b014f81..a8880a700 100644
--- a/tests/unit/utils/test_log.py
+++ b/tests/unit/utils/test_log.py
@@ -22,11 +22,9 @@ import argparse
import itertools
import sys
import warnings
-import dataclasses
import pytest
import _pytest.logging # pylint: disable=import-private-name
-from qutebrowser.qt import core as qtcore
from qutebrowser import qutebrowser
from qutebrowser.utils import log
@@ -241,7 +239,7 @@ class TestInitLog:
@pytest.fixture(autouse=True)
def setup(self, mocker):
- mocker.patch('qutebrowser.utils.log.qtcore.qInstallMessageHandler',
+ mocker.patch('qutebrowser.utils.qtlog.qtcore.qInstallMessageHandler',
autospec=True)
yield
# Make sure logging is in a sensible default state
@@ -405,27 +403,3 @@ def test_warning_still_errors():
# Mainly a sanity check after the tests messing with warnings above.
with pytest.raises(UserWarning):
warnings.warn("error", UserWarning)
-
-
-class TestQtMessageHandler:
-
- @dataclasses.dataclass
- class Context:
-
- """Fake QMessageLogContext."""
-
- function: str = None
- category: str = None
- file: str = None
- line: int = None
-
- @pytest.fixture(autouse=True)
- def init_args(self):
- parser = qutebrowser.get_argparser()
- args = parser.parse_args([])
- log.init_log(args)
-
- def test_empty_message(self, caplog):
- """Make sure there's no crash with an empty message."""
- log.qt_message_handler(qtcore.QtMsgType.QtDebugMsg, self.Context(), "")
- assert caplog.messages == ["Logged empty message!"]