summaryrefslogtreecommitdiff
path: root/scripts/dev/misc_checks.py
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2020-11-03 18:58:02 +0100
committerFlorian Bruhin <me@the-compiler.org>2020-11-03 23:06:11 +0100
commitd6e1d7847707c4605ac3373ee8e70eeea1333079 (patch)
tree4e0f388b5449d900516a4a8852bed511f1f6979a /scripts/dev/misc_checks.py
parent963df3b271113a5515e10f878496355a6dcaf9af (diff)
downloadqutebrowser-d6e1d7847707c4605ac3373ee8e70eeea1333079.tar.gz
qutebrowser-d6e1d7847707c4605ac3373ee8e70eeea1333079.zip
tests: Use three-argument form of monkeypatch
Diffstat (limited to 'scripts/dev/misc_checks.py')
-rw-r--r--scripts/dev/misc_checks.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/dev/misc_checks.py b/scripts/dev/misc_checks.py
index 2dd9e210b..e168bfff2 100644
--- a/scripts/dev/misc_checks.py
+++ b/scripts/dev/misc_checks.py
@@ -153,6 +153,11 @@ def check_spelling(args: argparse.Namespace) -> Optional[bool]:
re.compile(r': typing\.'),
"Don't use typing.SomeType, do 'from typing import SomeType' instead.",
),
+ (
+ re.compile(r"""monkeypatch\.setattr\(['"]"""),
+ "Don't use monkeypatch.setattr('obj.attr', value), use "
+ "setattr(obj, 'attr', value) instead.",
+ ),
]
# Files which should be ignored, e.g. because they come from another