diff options
| author | Florian Bruhin <me@the-compiler.org> | 2021-12-02 18:02:25 +0100 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2021-12-03 12:04:59 +0100 |
| commit | 4d13280994d9b476256861b93efabad55880bd64 (patch) | |
| tree | fdfdf144ae693242a92a8e39528930e1e94d2d07 /qutebrowser | |
| parent | 1ca68e6280f44493e0976f3535ae765dd2b6c90e (diff) | |
| download | qutebrowser-4d13280994d9b476256861b93efabad55880bd64.tar.gz qutebrowser-4d13280994d9b476256861b93efabad55880bd64.zip | |
pylint: Fix some legitimate issues
Diffstat (limited to 'qutebrowser')
| -rw-r--r-- | qutebrowser/browser/webengine/notification.py | 2 | ||||
| -rw-r--r-- | qutebrowser/completion/models/miscmodels.py | 4 | ||||
| -rw-r--r-- | qutebrowser/config/websettings.py | 1 | ||||
| -rw-r--r-- | qutebrowser/misc/guiprocess.py | 2 |
4 files changed, 4 insertions, 5 deletions
diff --git a/qutebrowser/browser/webengine/notification.py b/qutebrowser/browser/webengine/notification.py index f8e1a59b1..e943e44e9 100644 --- a/qutebrowser/browser/webengine/notification.py +++ b/qutebrowser/browser/webengine/notification.py @@ -722,7 +722,7 @@ class DBusNotificationAdapter(AbstractNotificationAdapter): } def __init__(self, parent: QObject = None) -> None: - super().__init__(bridge) + super().__init__(parent) assert _notifications_supported() if utils.is_windows: diff --git a/qutebrowser/completion/models/miscmodels.py b/qutebrowser/completion/models/miscmodels.py index 7642bf904..d8ebafb29 100644 --- a/qutebrowser/completion/models/miscmodels.py +++ b/qutebrowser/completion/models/miscmodels.py @@ -230,9 +230,7 @@ def _qdatetime_to_completion_format(qdate): if not qdate.isValid(): ts = 0 else: - ts = qdate.toMSecsSinceEpoch() - if ts < 0: - ts = 0 + ts = max(qdate.toMSecsSinceEpoch(), 0) pydate = datetime.datetime.fromtimestamp(ts / 1000) return pydate.strftime(config.val.completion.timestamp_format) diff --git a/qutebrowser/config/websettings.py b/qutebrowser/config/websettings.py index 7556d2b6d..41aeec6a3 100644 --- a/qutebrowser/config/websettings.py +++ b/qutebrowser/config/websettings.py @@ -238,6 +238,7 @@ def user_agent(url: QUrl = None) -> str: def init(args: argparse.Namespace) -> None: """Initialize all QWeb(Engine)Settings.""" + utils.unused(args) if objects.backend == usertypes.Backend.QtWebEngine: from qutebrowser.browser.webengine import webenginesettings webenginesettings.init() diff --git a/qutebrowser/misc/guiprocess.py b/qutebrowser/misc/guiprocess.py index c93fad09b..8e9747ad8 100644 --- a/qutebrowser/misc/guiprocess.py +++ b/qutebrowser/misc/guiprocess.py @@ -262,7 +262,7 @@ class GUIProcess(QObject): QProcess.Crashed: f"{what.capitalize()} crashed", QProcess.Timedout: f"{what.capitalize()} timed out", QProcess.WriteError: f"Write error for {what}", - QProcess.WriteError: f"Read error for {what}", + QProcess.ReadError: f"Read error for {what}", } error_string = self._proc.errorString() msg = ': '.join([error_descriptions[error], error_string]) |