diff options
| author | Florian Bruhin <git@the-compiler.org> | 2018-07-09 23:38:47 +0200 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2018-07-11 17:07:59 +0200 |
| commit | c2ff32d92ba9bf40ff53498ee04a4124d4993c85 (patch) | |
| tree | aa8130a54e7ea9b58f2b4192954deff26fd97d12 /qutebrowser/browser/webkit/network/filescheme.py | |
| parent | 718f73be2eb062f4893a463bca34c18feeded251 (diff) | |
| download | qutebrowser-v1.3.x.tar.gz qutebrowser-v1.3.x.zip | |
CVE-2018-10895: Fix CSRF issues with qute://settings/set URLv1.3.x
In ffc29ee043ae7336d9b9dcc029a05bf7a3f994e8 (part of v1.0.0), a
qute://settings/set URL was added to change settings.
Contrary to what I apparently believed at the time, it *is* possible for
websites to access `qute://*` URLs (i.e., neither QtWebKit nor QtWebEngine
prohibit such requests, other than the usual cross-origin rules).
In other words, this means a website can e.g. have an `<img>` tag which loads a
`qute://settings/set` URL, which then sets `editor.command` to a bash script.
The result of that is arbitrary code execution.
Fixes #4060
See #2332
(cherry picked from commit 43e58ac865ff862c2008c510fc5f7627e10b4660)
Diffstat (limited to 'qutebrowser/browser/webkit/network/filescheme.py')
| -rw-r--r-- | qutebrowser/browser/webkit/network/filescheme.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/qutebrowser/browser/webkit/network/filescheme.py b/qutebrowser/browser/webkit/network/filescheme.py index 840ed6a4a..a29674e25 100644 --- a/qutebrowser/browser/webkit/network/filescheme.py +++ b/qutebrowser/browser/webkit/network/filescheme.py @@ -111,11 +111,13 @@ def dirbrowser_html(path): return html.encode('UTF-8', errors='xmlcharrefreplace') -def handler(request): +def handler(request, _operation, _current_url): """Handler for a file:// URL. Args: request: QNetworkRequest to answer to. + _operation: The HTTP operation being done. + _current_url: The page we're on currently. Return: A QNetworkReply for directories, None for files. |