diff options
| author | Florian Bruhin <git@the-compiler.org> | 2015-02-09 07:46:31 +0100 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2015-02-11 23:15:41 +0100 |
| commit | a09503d5b5906c4adcf361721705b7334512d605 (patch) | |
| tree | 8782d62fd342f50d4166916d77e98360845bc418 | |
| parent | 659fa026138d453cb45c53f6f5e7ed3f97fa84e8 (diff) | |
| download | qutebrowser-a09503d5b5906c4adcf361721705b7334512d605.tar.gz qutebrowser-a09503d5b5906c4adcf361721705b7334512d605.zip | |
Don't log javascript console messages by default.
| -rw-r--r-- | doc/help/settings.asciidoc | 12 | ||||
| -rw-r--r-- | qutebrowser/browser/webpage.py | 3 | ||||
| -rw-r--r-- | qutebrowser/config/configdata.py | 4 |
3 files changed, 18 insertions, 1 deletions
diff --git a/doc/help/settings.asciidoc b/doc/help/settings.asciidoc index 8422d9b61..dfe65e14c 100644 --- a/doc/help/settings.asciidoc +++ b/doc/help/settings.asciidoc @@ -18,6 +18,7 @@ |<<general-site-specific-quirks,site-specific-quirks>>|Enable workarounds for broken sites. |<<general-default-encoding,default-encoding>>|Default encoding to use for websites. |<<general-new-instance-open-target,new-instance-open-target>>|How to open links in an existing instance if a new one is launched. +|<<general-log-javascript-console,log-javascript-console>>|Whether to log javascript console messages. |============== .Quick reference for section ``ui'' @@ -361,6 +362,17 @@ Valid values: Default: +pass:[window]+ +[[general-log-javascript-console]] +=== log-javascript-console +Whether to log javascript console messages. + +Valid values: + + * +true+ + * +false+ + +Default: +pass:[false]+ + == ui General options related to the user interface. diff --git a/qutebrowser/browser/webpage.py b/qutebrowser/browser/webpage.py index 9c7eb6864..dbfee1830 100644 --- a/qutebrowser/browser/webpage.py +++ b/qutebrowser/browser/webpage.py @@ -310,7 +310,8 @@ class BrowserPage(QWebPage): def javaScriptConsoleMessage(self, msg, line, source): """Override javaScriptConsoleMessage to use debug log.""" - log.js.debug("[{}:{}] {}".format(source, line, msg)) + if config.get('general', 'log-javascript-console'): + log.js.debug("[{}:{}] {}".format(source, line, msg)) def chooseFile(self, _frame, suggested_file): """Override QWebPage's chooseFile to be able to chose a file to upload. diff --git a/qutebrowser/config/configdata.py b/qutebrowser/config/configdata.py index 99886eccd..fc6130b80 100644 --- a/qutebrowser/config/configdata.py +++ b/qutebrowser/config/configdata.py @@ -190,6 +190,10 @@ DATA = collections.OrderedDict([ SettingValue(typ.NewInstanceOpenTarget(), 'window'), "How to open links in an existing instance if a new one is " "launched."), + + ('log-javascript-console', + SettingValue(typ.Bool(), 'false'), + "Whether to log javascript console messages."), )), ('ui', sect.KeyValue( |