summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2019-03-18 11:41:47 +0100
committerFlorian Bruhin <me@the-compiler.org>2019-03-18 11:45:14 +0100
commit247d622df04edf39906ad5bf7a7458ed4af94b46 (patch)
tree3a548a0148eff7ea8c829031ad0a69e9a226fc0b
parent4a7e8017f89596a32abf5c395610c1472d16d431 (diff)
downloadqutebrowser-247d622df04edf39906ad5bf7a7458ed4af94b46.tar.gz
qutebrowser-247d622df04edf39906ad5bf7a7458ed4af94b46.zip
Use window.hasOwnProperty for window._qutebrowser
With an element like this in the page: <h2 id="_qutebrowser">qutebrowser</h2> accessing window._qutebrowser will return the HTMLElement (thanks, JS...), making qutebrowser's JS think it's already initialized when it actually isn't. Fixes #4633
-rw-r--r--qutebrowser/javascript/global_wrapper.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/qutebrowser/javascript/global_wrapper.js b/qutebrowser/javascript/global_wrapper.js
index a302bd5d1..0762fd85d 100644
--- a/qutebrowser/javascript/global_wrapper.js
+++ b/qutebrowser/javascript/global_wrapper.js
@@ -1,6 +1,6 @@
(function() {
"use strict";
- if (!("_qutebrowser" in window)) {
+ if (!window.hasOwnProperty("_qutebrowser")) {
window._qutebrowser = {"initialized": {}};
}