From 247d622df04edf39906ad5bf7a7458ed4af94b46 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 18 Mar 2019 11:41:47 +0100 Subject: Use window.hasOwnProperty for window._qutebrowser With an element like this in the page:

qutebrowser

accessing window._qutebrowser will return the HTMLElement (thanks, JS...), making qutebrowser's JS think it's already initialized when it actually isn't. Fixes #4633 --- qutebrowser/javascript/global_wrapper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/javascript/global_wrapper.js b/qutebrowser/javascript/global_wrapper.js index a302bd5d1..0762fd85d 100644 --- a/qutebrowser/javascript/global_wrapper.js +++ b/qutebrowser/javascript/global_wrapper.js @@ -1,6 +1,6 @@ (function() { "use strict"; - if (!("_qutebrowser" in window)) { + if (!window.hasOwnProperty("_qutebrowser")) { window._qutebrowser = {"initialized": {}}; } -- cgit v1.2.3-54-g00ecf