diff options
| author | Florian Bruhin <git@the-compiler.org> | 2018-06-08 15:13:48 +0200 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2018-06-08 15:20:33 +0200 |
| commit | e54f2a090a5f0c508e7b469a6dd04c109acb702e (patch) | |
| tree | 38867898dcb2ec65fc36866f40934bcdc742ab06 | |
| parent | 55ce4b7ed26e0e78bcd738215173981dafdde94d (diff) | |
| download | qutebrowser-e54f2a090a5f0c508e7b469a6dd04c109acb702e.tar.gz qutebrowser-e54f2a090a5f0c508e7b469a6dd04c109acb702e.zip | |
Improve RWHV typecheck for focusProxy
(cherry picked from commit cc497bf2ea59e23604bad0d4d6b980feaa9126e5)
| -rw-r--r-- | qutebrowser/browser/webengine/webview.py | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/qutebrowser/browser/webengine/webview.py b/qutebrowser/browser/webengine/webview.py index f29b67708..c009181ed 100644 --- a/qutebrowser/browser/webengine/webview.py +++ b/qutebrowser/browser/webengine/webview.py @@ -72,12 +72,10 @@ class WebEngineView(QWebEngineView): if proxy is not None: return proxy - # We only want the RenderWidgetHostViewQtDelegateWidget - # (which is a QWidget) but not e.g. a QMenu. - # pylint: disable=unidiomatic-typecheck + # We don't want e.g. a QMenu. + rwhv_class = 'QtWebEngineCore::RenderWidgetHostViewQtDelegateWidget' children = [child for child in self.findChildren(QWidget) - if type(child) == QWidget] - # pylint: enable=unidiomatic-typecheck + if child.inherits(rwhv_class)] if not children: return None |