From e54f2a090a5f0c508e7b469a6dd04c109acb702e Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 8 Jun 2018 15:13:48 +0200 Subject: Improve RWHV typecheck for focusProxy (cherry picked from commit cc497bf2ea59e23604bad0d4d6b980feaa9126e5) --- qutebrowser/browser/webengine/webview.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/qutebrowser/browser/webengine/webview.py b/qutebrowser/browser/webengine/webview.py index f29b67708..c009181ed 100644 --- a/qutebrowser/browser/webengine/webview.py +++ b/qutebrowser/browser/webengine/webview.py @@ -72,12 +72,10 @@ class WebEngineView(QWebEngineView): if proxy is not None: return proxy - # We only want the RenderWidgetHostViewQtDelegateWidget - # (which is a QWidget) but not e.g. a QMenu. - # pylint: disable=unidiomatic-typecheck + # We don't want e.g. a QMenu. + rwhv_class = 'QtWebEngineCore::RenderWidgetHostViewQtDelegateWidget' children = [child for child in self.findChildren(QWidget) - if type(child) == QWidget] - # pylint: enable=unidiomatic-typecheck + if child.inherits(rwhv_class)] if not children: return None -- cgit v1.2.3-54-g00ecf