summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <git@the-compiler.org>2018-06-11 21:43:27 +0200
committerFlorian Bruhin <git@the-compiler.org>2018-06-11 21:45:09 +0200
commit146f8e72ae96b995b225170da7645448a0a95942 (patch)
tree817b06d0fc75672d3b10130bc5b9330ae7a3f05f
parentf61662fa52299f3adb25ee3842d0e642bd365e41 (diff)
downloadqutebrowser-146f8e72ae96b995b225170da7645448a0a95942.tar.gz
qutebrowser-146f8e72ae96b995b225170da7645448a0a95942.zip
Handle multiple visible children when finding lost focusProxy
When we click a QTBUG link (to open in a new tab) from Qt's codereview, we get two RWHV objects which both are visible. Experimenting with .setEnabled(False) it looks like it's (hopefully always...) the last one which is the one to use. (cherry picked from commit 67c67db23074e28d85d46f5a4c02073bc51444c5)
-rw-r--r--qutebrowser/browser/webengine/webview.py6
1 files changed, 1 insertions, 5 deletions
diff --git a/qutebrowser/browser/webengine/webview.py b/qutebrowser/browser/webengine/webview.py
index 84caceedd..03cdd035f 100644
--- a/qutebrowser/browser/webengine/webview.py
+++ b/qutebrowser/browser/webengine/webview.py
@@ -80,11 +80,7 @@ class WebEngineView(QWebEngineView):
log.webview.debug("Found possibly lost focusProxy: {}"
.format(children))
- if not children:
- return None
-
- assert len(children) == 1, children
- return children[0]
+ return children[-1] if children else None
def shutdown(self):
self.page().shutdown()