From 146f8e72ae96b995b225170da7645448a0a95942 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 11 Jun 2018 21:43:27 +0200 Subject: Handle multiple visible children when finding lost focusProxy When we click a QTBUG link (to open in a new tab) from Qt's codereview, we get two RWHV objects which both are visible. Experimenting with .setEnabled(False) it looks like it's (hopefully always...) the last one which is the one to use. (cherry picked from commit 67c67db23074e28d85d46f5a4c02073bc51444c5) --- qutebrowser/browser/webengine/webview.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/qutebrowser/browser/webengine/webview.py b/qutebrowser/browser/webengine/webview.py index 84caceedd..03cdd035f 100644 --- a/qutebrowser/browser/webengine/webview.py +++ b/qutebrowser/browser/webengine/webview.py @@ -80,11 +80,7 @@ class WebEngineView(QWebEngineView): log.webview.debug("Found possibly lost focusProxy: {}" .format(children)) - if not children: - return None - - assert len(children) == 1, children - return children[0] + return children[-1] if children else None def shutdown(self): self.page().shutdown() -- cgit v1.2.3-54-g00ecf