diff options
| author | Florian Bruhin <me@the-compiler.org> | 2020-06-23 18:21:51 +0200 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2020-06-23 18:21:51 +0200 |
| commit | adbaf092a26f77d028974add44c55de5bc17a9be (patch) | |
| tree | f158306de589a6364a5e1f2b7d55091ca85c0b12 | |
| parent | 523fcfdc17b6c57f4614ec38fd369fdb935edf32 (diff) | |
| download | qutebrowser-adbaf092a26f77d028974add44c55de5bc17a9be.tar.gz qutebrowser-adbaf092a26f77d028974add44c55de5bc17a9be.zip | |
Delete widget in WrapperLayout.unwrap()
This was removed in f5f3bf63b58d5a2a73a777b199b9dbc0b360fb66 but is still
needed so that the underlying QWebEngineView is actually deleted with Qt <
5.12. Otherwise, test_spawning_an_editor_and_closing_the_tab in
test_editor_bdd.py would fail because the element doesn't actually vanish.
| -rw-r--r-- | qutebrowser/misc/miscwidgets.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/qutebrowser/misc/miscwidgets.py b/qutebrowser/misc/miscwidgets.py index 95786e3c7..f8dfaa69c 100644 --- a/qutebrowser/misc/miscwidgets.py +++ b/qutebrowser/misc/miscwidgets.py @@ -279,6 +279,7 @@ class WrapperLayout(QLayout): return assert self._container is not None self._widget.setParent(None) # type: ignore[call-overload] + self._widget.deleteLater() self._widget = None self._container.setFocusProxy(None) # type: ignore[arg-type] |