From adbaf092a26f77d028974add44c55de5bc17a9be Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 23 Jun 2020 18:21:51 +0200 Subject: Delete widget in WrapperLayout.unwrap() This was removed in f5f3bf63b58d5a2a73a777b199b9dbc0b360fb66 but is still needed so that the underlying QWebEngineView is actually deleted with Qt < 5.12. Otherwise, test_spawning_an_editor_and_closing_the_tab in test_editor_bdd.py would fail because the element doesn't actually vanish. --- qutebrowser/misc/miscwidgets.py | 1 + 1 file changed, 1 insertion(+) diff --git a/qutebrowser/misc/miscwidgets.py b/qutebrowser/misc/miscwidgets.py index 95786e3c7..f8dfaa69c 100644 --- a/qutebrowser/misc/miscwidgets.py +++ b/qutebrowser/misc/miscwidgets.py @@ -279,6 +279,7 @@ class WrapperLayout(QLayout): return assert self._container is not None self._widget.setParent(None) # type: ignore[call-overload] + self._widget.deleteLater() self._widget = None self._container.setFocusProxy(None) # type: ignore[arg-type] -- cgit v1.2.3-54-g00ecf