summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2020-06-25 15:45:32 +0200
committerFlorian Bruhin <me@the-compiler.org>2020-06-25 16:02:36 +0200
commit156738195e027e40cadb716b3c3c7b163a09bb97 (patch)
tree41478a98ede451276c517f17fadaa7fcd442cd0b
parent713592e85193bea3bcc9bc0d9d064b4e5f38886f (diff)
downloadqutebrowser-156738195e027e40cadb716b3c3c7b163a09bb97.tar.gz
qutebrowser-156738195e027e40cadb716b3c3c7b163a09bb97.zip
Change permission workaround logger to debug
Now that we know how this happens (notification permissions in incognito mode), we don't need to log a warning here.
-rw-r--r--qutebrowser/browser/webengine/webenginetab.py12
1 files changed, 9 insertions, 3 deletions
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py
index c161afd0c..1688aadd7 100644
--- a/qutebrowser/browser/webengine/webenginetab.py
+++ b/qutebrowser/browser/webengine/webenginetab.py
@@ -40,7 +40,7 @@ from qutebrowser.browser.webengine import (webview, webengineelem, tabhistory,
webenginesettings, certificateerror)
from qutebrowser.misc import miscwidgets, objects
from qutebrowser.utils import (usertypes, qtutils, log, javascript, utils,
- message, objreg, jinja, debug)
+ message, objreg, jinja, debug, qtutils)
from qutebrowser.keyinput import modeman
from qutebrowser.qt import sip
@@ -978,8 +978,14 @@ class _WebEnginePermissions(QObject):
if not url.isValid():
# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-85116
- log.webview.warning("Ignoring feature permission {} for invalid "
- "URL {}".format(permission_str, url))
+ is_qtbug = (qtutils.version_check('5.15.0',
+ compiled=False,
+ exact=True) and
+ self._tab.is_private and
+ feature == QWebEnginePage.Notifications)
+ logger = log.webview.debug if is_qtbug else log.webview.warning
+ logger("Ignoring feature permission {} for invalid URL {}".format(
+ permission_str, url))
deny_permission()
return