From 156738195e027e40cadb716b3c3c7b163a09bb97 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 25 Jun 2020 15:45:32 +0200 Subject: Change permission workaround logger to debug Now that we know how this happens (notification permissions in incognito mode), we don't need to log a warning here. --- qutebrowser/browser/webengine/webenginetab.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index c161afd0c..1688aadd7 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -40,7 +40,7 @@ from qutebrowser.browser.webengine import (webview, webengineelem, tabhistory, webenginesettings, certificateerror) from qutebrowser.misc import miscwidgets, objects from qutebrowser.utils import (usertypes, qtutils, log, javascript, utils, - message, objreg, jinja, debug) + message, objreg, jinja, debug, qtutils) from qutebrowser.keyinput import modeman from qutebrowser.qt import sip @@ -978,8 +978,14 @@ class _WebEnginePermissions(QObject): if not url.isValid(): # WORKAROUND for https://bugreports.qt.io/browse/QTBUG-85116 - log.webview.warning("Ignoring feature permission {} for invalid " - "URL {}".format(permission_str, url)) + is_qtbug = (qtutils.version_check('5.15.0', + compiled=False, + exact=True) and + self._tab.is_private and + feature == QWebEnginePage.Notifications) + logger = log.webview.debug if is_qtbug else log.webview.warning + logger("Ignoring feature permission {} for invalid URL {}".format( + permission_str, url)) deny_permission() return -- cgit v1.2.3-54-g00ecf