summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2023-06-29 22:10:44 +0200
committerFlorian Bruhin <me@the-compiler.org>2023-06-29 22:10:44 +0200
commitd13bd0675de0cca9168ac930db4184ac76d4dece (patch)
treefc473dfa122a7abba1be1194c9e1f3452c42d6cf
parent7b1029653fbcc9155f9d23e162e629272540c520 (diff)
downloadqutebrowser-d13bd0675de0cca9168ac930db4184ac76d4dece.tar.gz
qutebrowser-d13bd0675de0cca9168ac930db4184ac76d4dece.zip
qt6 mypy: Fix handling of AbstractTab.is_deleted()
-rw-r--r--qutebrowser/browser/browsertab.py11
1 files changed, 7 insertions, 4 deletions
diff --git a/qutebrowser/browser/browsertab.py b/qutebrowser/browser/browsertab.py
index 9692be483..093380fc0 100644
--- a/qutebrowser/browser/browsertab.py
+++ b/qutebrowser/browser/browsertab.py
@@ -1181,8 +1181,7 @@ class AbstractTab(QWidget):
@pyqtSlot(bool)
def _on_load_finished(self, ok: bool) -> None:
assert self._widget is not None
- # FIXME:mypy PyQt6-stubs issue?
- if sip.isdeleted(self._widget):
+ if self.is_deleted():
# https://github.com/qutebrowser/qutebrowser/issues/3498
return
@@ -1342,5 +1341,9 @@ class AbstractTab(QWidget):
def is_deleted(self) -> bool:
assert self._widget is not None
- # FIXME:mypy PyQt6-stubs issue?
- return sip.isdeleted(self._widget)
+ # FIXME:v4 cast needed for QtWebKit
+ if machinery.IS_QT6:
+ widget = cast(QWidget, self._widget)
+ else:
+ widget = self._widget
+ return sip.isdeleted(widget)