From d13bd0675de0cca9168ac930db4184ac76d4dece Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 29 Jun 2023 22:10:44 +0200 Subject: qt6 mypy: Fix handling of AbstractTab.is_deleted() --- qutebrowser/browser/browsertab.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/qutebrowser/browser/browsertab.py b/qutebrowser/browser/browsertab.py index 9692be483..093380fc0 100644 --- a/qutebrowser/browser/browsertab.py +++ b/qutebrowser/browser/browsertab.py @@ -1181,8 +1181,7 @@ class AbstractTab(QWidget): @pyqtSlot(bool) def _on_load_finished(self, ok: bool) -> None: assert self._widget is not None - # FIXME:mypy PyQt6-stubs issue? - if sip.isdeleted(self._widget): + if self.is_deleted(): # https://github.com/qutebrowser/qutebrowser/issues/3498 return @@ -1342,5 +1341,9 @@ class AbstractTab(QWidget): def is_deleted(self) -> bool: assert self._widget is not None - # FIXME:mypy PyQt6-stubs issue? - return sip.isdeleted(self._widget) + # FIXME:v4 cast needed for QtWebKit + if machinery.IS_QT6: + widget = cast(QWidget, self._widget) + else: + widget = self._widget + return sip.isdeleted(widget) -- cgit v1.2.3-54-g00ecf