summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2021-01-15 11:42:42 +0100
committerFlorian Bruhin <me@the-compiler.org>2021-01-15 11:43:23 +0100
commit485a3173797a356f90cb539802c73685d9b93371 (patch)
tree3d0e6985d7095e5e66cd3f82985b23a5de15c177
parent8015988bb05f8a1174c582412b941c697a4e96b4 (diff)
downloadqutebrowser-485a3173797a356f90cb539802c73685d9b93371.tar.gz
qutebrowser-485a3173797a356f90cb539802c73685d9b93371.zip
sql: Remove HistoryProgress reusability
Not actually needed and complicates things
-rw-r--r--qutebrowser/browser/history.py5
-rw-r--r--tests/unit/browser/test_history.py1
2 files changed, 1 insertions, 5 deletions
diff --git a/qutebrowser/browser/history.py b/qutebrowser/browser/history.py
index 6fcc140a1..d81accc95 100644
--- a/qutebrowser/browser/history.py
+++ b/qutebrowser/browser/history.py
@@ -46,9 +46,6 @@ class HistoryProgress:
"""
def __init__(self):
- self._reset()
-
- def _reset(self):
self._progress = None
self._value = 0
@@ -65,6 +62,7 @@ class HistoryProgress:
def set_maximum(self, maximum):
"""Set the progress maximum as soon as we know about it."""
+ assert self._progress is not None
self._progress.setMaximum(maximum)
QApplication.processEvents()
@@ -82,7 +80,6 @@ class HistoryProgress:
"""
if self._progress is not None:
self._progress.hide()
- self._reset()
class CompletionMetaInfo(sql.SqlTable):
diff --git a/tests/unit/browser/test_history.py b/tests/unit/browser/test_history.py
index e80f30d4c..e5a3f1ee8 100644
--- a/tests/unit/browser/test_history.py
+++ b/tests/unit/browser/test_history.py
@@ -491,7 +491,6 @@ class TestHistoryProgress:
assert progress._value == 1
progress.finish()
assert progress._progress is None
- assert progress._value == 0
def test_gui(self, qtbot, progress):
progress.start("Hello World")