From 485a3173797a356f90cb539802c73685d9b93371 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 15 Jan 2021 11:42:42 +0100 Subject: sql: Remove HistoryProgress reusability Not actually needed and complicates things --- qutebrowser/browser/history.py | 5 +---- tests/unit/browser/test_history.py | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/qutebrowser/browser/history.py b/qutebrowser/browser/history.py index 6fcc140a1..d81accc95 100644 --- a/qutebrowser/browser/history.py +++ b/qutebrowser/browser/history.py @@ -46,9 +46,6 @@ class HistoryProgress: """ def __init__(self): - self._reset() - - def _reset(self): self._progress = None self._value = 0 @@ -65,6 +62,7 @@ class HistoryProgress: def set_maximum(self, maximum): """Set the progress maximum as soon as we know about it.""" + assert self._progress is not None self._progress.setMaximum(maximum) QApplication.processEvents() @@ -82,7 +80,6 @@ class HistoryProgress: """ if self._progress is not None: self._progress.hide() - self._reset() class CompletionMetaInfo(sql.SqlTable): diff --git a/tests/unit/browser/test_history.py b/tests/unit/browser/test_history.py index e80f30d4c..e5a3f1ee8 100644 --- a/tests/unit/browser/test_history.py +++ b/tests/unit/browser/test_history.py @@ -491,7 +491,6 @@ class TestHistoryProgress: assert progress._value == 1 progress.finish() assert progress._progress is None - assert progress._value == 0 def test_gui(self, qtbot, progress): progress.start("Hello World") -- cgit v1.2.3-54-g00ecf