diff options
| author | Florian Bruhin <me@the-compiler.org> | 2023-02-14 19:12:54 +0100 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2023-02-14 19:12:54 +0100 |
| commit | efb0cbb4a7b2fc3319ebc54e40ab63457937380d (patch) | |
| tree | 93e900d1db447b710d9047a7d19fc71e06e154d4 | |
| parent | 934e87c13394fc7ad832108ec534431c717f20b6 (diff) | |
| download | qutebrowser-efb0cbb4a7b2fc3319ebc54e40ab63457937380d.tar.gz qutebrowser-efb0cbb4a7b2fc3319ebc54e40ab63457937380d.zip | |
Add missing return after PAC parsing exception
Otherwise, 'pacscript' in the line below would cause a NameError
| -rw-r--r-- | qutebrowser/browser/network/pac.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/qutebrowser/browser/network/pac.py b/qutebrowser/browser/network/pac.py index 99078ab20..be2ec3093 100644 --- a/qutebrowser/browser/network/pac.py +++ b/qutebrowser/browser/network/pac.py @@ -287,6 +287,8 @@ class PACFetcher(QObject): error = "Invalid encoding of a PAC file: {}" self._error_message = error.format(e) log.network.exception(self._error_message) + return + try: self._pac = PACResolver(pacscript) log.network.debug("Successfully evaluated PAC file.") @@ -294,6 +296,7 @@ class PACFetcher(QObject): error = "Error in PAC evaluation: {}" self._error_message = error.format(e) log.network.exception(self._error_message) + self._manager = None self._reply = None self.finished.emit() |